cgroup-util: explain why cg_pidref_get_path() cannot be ported over to pidfd helpers (yet)

See also: https://github.com/systemd/systemd/pull/35242#issuecomment-2506686806
2025-01-04 17:48:23 +01:00
parent f1ba5c900b
commit 9598708a12
1 changed files with 4 additions and 0 deletions
@@ -861,6 +861,10 @@ int cg_pidref_get_path(const char *controller, const PidRef *pidref, char **ret_
        if (!pidref_is_set(pidref))
                return -ESRCH;

+        // XXX: Ideally we'd use pidfd_get_cgroupid() + cg_path_from_cgroupid() here, to extract this
+        // bit of information from pidfd directly. However, the latter requires privilege and it's
+        // not entirely clear how to handle cgroups from outer namespace.
+
        r = cg_pid_get_path(controller, pidref->pid, &path);
        if (r < 0)
                return r;