From 9e3fbc386f319eb270266329e68bae97dec4258c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Thu, 8 Oct 2026 12:35:20 +0200 Subject: [PATCH] bus-unit-util: fix return value for CPUAffinity=numa sd_bus_message_append() returns 0 on success, but the convert helpers are expected to return 1 when the assignment was handled. Returning 0 here was harmless for callers that only check for errors, but it is inconsistent with the other helpers and it would trip the new serialization test. (cherry picked from commit 5b578462bc66795ea7f3a20ff1d21e0ae2afee28) --- src/shared/bus-unit-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c index f48b6be037..e4644dd454 100644 --- a/src/shared/bus-unit-util.c +++ b/src/shared/bus-unit-util.c @@ -1476,7 +1476,7 @@ static int bus_append_cpu_affinity(sd_bus_message *m, const char *field, const c r = sd_bus_message_append(m, "(sv)", "CPUAffinityFromNUMA", "b", true); if (r < 0) return bus_log_create_error(r); - return r; + return 1; } return bus_append_parse_cpu_set(m, field, eq);