From f63ef9370342d4293a00a1ae9f80d0756c67c792 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 16 Jul 2020 08:32:15 +0200 Subject: [PATCH 1/2] execute: fix if check Fixes: coverity 1430459 --- src/core/execute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/execute.c b/src/core/execute.c index 70b7b8dc3c..a67eb716e4 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -2630,7 +2630,7 @@ static int apply_mount_namespace( if (streq_ptr(runtime->var_tmp_dir, RUN_SYSTEMD_EMPTY)) var_tmp_dir = runtime->var_tmp_dir; - else if (runtime->tmp_dir) + else if (runtime->var_tmp_dir) var_tmp_dir = strjoina(runtime->var_tmp_dir, "/tmp"); } From 8e32ad955793c67a5a2cd177b222fa830c30d7c9 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 16 Jul 2020 08:32:23 +0200 Subject: [PATCH 2/2] machine: fix if check Fixes: coverity 1430462 --- src/machine/machined-varlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/machine/machined-varlink.c b/src/machine/machined-varlink.c index 892de7071a..058ee5c8ea 100644 --- a/src/machine/machined-varlink.c +++ b/src/machine/machined-varlink.c @@ -268,7 +268,7 @@ static int group_lookup_name(Manager *m, const char *name, gid_t *ret_gid) { return -ENOMEM; machine = hashmap_get(m->machines, mn); - if (!mn) + if (!machine) return -ESRCH; if (machine->class != MACHINE_CONTAINER)