From 9f691ad3c073f60df9b7902fab46b41e00bbb9c5 Mon Sep 17 00:00:00 2001 From: Michael Vogt Date: Wed, 25 Mar 2026 11:53:36 +0100 Subject: [PATCH] varlink: comment that "more" flag IDL comment is API External tools that use the systemd varlink ecosystem require to know if a specific varlink method supports/requires the "more" flag from the IDL. This is tracked upstream in https://github.com/varlink/varlink.github.io/issues/26 As an intermediate step systemd adds the (very nice) comments ``` # [Requires 'more' flag] or # [Supports 'more' flag] ``` to the various methods. This commit extends the comment around the code that adds the comment to clarify that this should be considered API and that the comment should not be changed as external tools (like e.g. the varlink-http-bridge) rely on it. --- src/libsystemd/sd-varlink/sd-varlink-idl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libsystemd/sd-varlink/sd-varlink-idl.c b/src/libsystemd/sd-varlink/sd-varlink-idl.c index 144450b702..22b6026a01 100644 --- a/src/libsystemd/sd-varlink/sd-varlink-idl.c +++ b/src/libsystemd/sd-varlink/sd-varlink-idl.c @@ -387,7 +387,10 @@ static int varlink_idl_format_symbol( /* Sooner or later we want to export this in a proper IDL language construct, see * https://github.com/varlink/varlink.github.io/issues/26 – but for now export this as a - * comment. */ + * comment. + * + * Until this is resolved upsteam, consider this comment part of the API (i.e. don't change + * only extend). It is used by tools like varlink-http-bridge. */ if ((symbol->symbol_flags & (SD_VARLINK_REQUIRES_MORE|SD_VARLINK_SUPPORTS_MORE)) != 0) { fputs(colors[COLOR_COMMENT], f); if (FLAGS_SET(symbol->symbol_flags, SD_VARLINK_REQUIRES_MORE))