From ad0f1d66f22fae92f5e0b4597e893c1f1dc15d61 Mon Sep 17 00:00:00 2001 From: Martin Pitt Date: Sun, 4 Oct 2026 07:27:31 +0000 Subject: [PATCH] vmspawn: log failures to dismiss completed QMP jobs Most errors that end the event loop are logged where they happen, except these two. Signed-off-by: Martin Pitt (cherry picked from commit 7681db4546d0eb3ef9160e90200ccaf5c9d7edc2) --- src/vmspawn/vmspawn-qmp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vmspawn/vmspawn-qmp.c b/src/vmspawn/vmspawn-qmp.c index 0ccfbfb1e2..3bee5ae4c1 100644 --- a/src/vmspawn/vmspawn-qmp.c +++ b/src/vmspawn/vmspawn-qmp.c @@ -1915,13 +1915,17 @@ static int dispatch_pending_job(VmspawnQmpBridge *bridge, sd_json_variant *data) /* Dismiss the concluded job before running the continuation */ _cleanup_(sd_json_variant_unrefp) sd_json_variant *dismiss_args = NULL; r = sd_json_buildo(&dismiss_args, SD_JSON_BUILD_PAIR_STRING("id", job_id)); - if (r < 0) + if (r < 0) { + log_error_errno(r, "Failed to build job-dismiss arguments for '%s': %m", job_id); return sd_event_exit(qmp_client_get_event(bridge->qmp), r); + } r = qmp_client_invoke(bridge->qmp, /* ret_slot= */ NULL, "job-dismiss", QMP_CLIENT_ARGS(dismiss_args), on_job_dismiss_complete, /* userdata= */ NULL); - if (r < 0) + if (r < 0) { + log_error_errno(r, "Failed to send job-dismiss for '%s': %m", job_id); return sd_event_exit(qmp_client_get_event(bridge->qmp), r); + } if (!job->on_concluded) return 1;