many: fix remaining check-pointer-deref issues
The updated parsing_hacks.h file uncovered a bunch of extra things that the check-pointer-deref coccinelle script flags. This commit fixes them to make the tree check-pointer-deref clean.
This commit is contained in:
@@ -86,6 +86,7 @@ static int netdev_create_fou_tunnel_message(NetDev *netdev, sd_netlink_message *
|
||||
|
||||
assert(netdev);
|
||||
assert(netdev->manager);
|
||||
assert(ret);
|
||||
|
||||
r = sd_genl_message_new(netdev->manager->genl, FOU_GENL_NAME, FOU_CMD_ADD, &m);
|
||||
if (r < 0)
|
||||
|
||||
@@ -104,6 +104,7 @@ static int netdev_l2tp_create_message_tunnel(NetDev *netdev, union in_addr_union
|
||||
assert(local_address);
|
||||
assert(netdev);
|
||||
assert(netdev->manager);
|
||||
assert(ret);
|
||||
|
||||
_cleanup_(sd_netlink_message_unrefp) sd_netlink_message *m = NULL;
|
||||
uint16_t encap_type;
|
||||
@@ -200,6 +201,7 @@ static int netdev_l2tp_create_message_session(NetDev *netdev, L2tpSession *sessi
|
||||
assert(netdev->manager);
|
||||
assert(session);
|
||||
assert(session->tunnel);
|
||||
assert(ret);
|
||||
|
||||
r = sd_genl_message_new(netdev->manager->genl, L2TP_GENL_NAME, L2TP_CMD_SESSION_CREATE, &m);
|
||||
if (r < 0)
|
||||
|
||||
@@ -239,6 +239,7 @@ static int netdev_macsec_create_message(NetDev *netdev, int command, sd_netlink_
|
||||
assert(netdev);
|
||||
assert(netdev->ifindex > 0);
|
||||
assert(netdev->manager);
|
||||
assert(ret);
|
||||
|
||||
r = sd_genl_message_new(netdev->manager->genl, MACSEC_GENL_NAME, command, &m);
|
||||
if (r < 0)
|
||||
|
||||
@@ -173,6 +173,8 @@ DEFINE_PRIVATE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
|
||||
int address_new(Address **ret) {
|
||||
_cleanup_(address_unrefp) Address *address = NULL;
|
||||
|
||||
assert(ret);
|
||||
|
||||
address = new(Address, 1);
|
||||
if (!address)
|
||||
return -ENOMEM;
|
||||
|
||||
@@ -456,6 +456,9 @@ static int dhcp4_server_parse_dns_server_string_and_warn(
|
||||
struct in_addr **addresses,
|
||||
size_t *n_addresses) {
|
||||
|
||||
assert(addresses);
|
||||
assert(n_addresses);
|
||||
|
||||
for (;;) {
|
||||
_cleanup_free_ char *word = NULL, *server_name = NULL;
|
||||
union in_addr_union address;
|
||||
|
||||
@@ -202,6 +202,10 @@ static int dhcp6_request_address(
|
||||
Address *existing;
|
||||
int r;
|
||||
|
||||
assert(link);
|
||||
assert(server_address);
|
||||
assert(ip6_addr);
|
||||
|
||||
r = address_new(&addr);
|
||||
if (r < 0)
|
||||
return log_oom();
|
||||
|
||||
@@ -677,6 +677,8 @@ static int persistent_storage_open(void) {
|
||||
int manager_new(Manager **ret, bool test_mode) {
|
||||
_cleanup_(manager_freep) Manager *m = NULL;
|
||||
|
||||
assert(ret);
|
||||
|
||||
m = new(Manager, 1);
|
||||
if (!m)
|
||||
return -ENOMEM;
|
||||
|
||||
@@ -131,6 +131,8 @@ DEFINE_PRIVATE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
|
||||
int nexthop_new(NextHop **ret) {
|
||||
_cleanup_(nexthop_unrefp) NextHop *nexthop = NULL;
|
||||
|
||||
assert(ret);
|
||||
|
||||
nexthop = new(NextHop, 1);
|
||||
if (!nexthop)
|
||||
return -ENOMEM;
|
||||
|
||||
@@ -245,6 +245,8 @@ DEFINE_PRIVATE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
|
||||
int route_new(Route **ret) {
|
||||
_cleanup_(route_unrefp) Route *route = NULL;
|
||||
|
||||
assert(ret);
|
||||
|
||||
route = new(Route, 1);
|
||||
if (!route)
|
||||
return -ENOMEM;
|
||||
|
||||
@@ -115,6 +115,8 @@ static int qdisc_new(QDiscKind kind, QDisc **ret) {
|
||||
_cleanup_(qdisc_unrefp) QDisc *qdisc = NULL;
|
||||
int r;
|
||||
|
||||
assert(ret);
|
||||
|
||||
if (kind == _QDISC_KIND_INVALID) {
|
||||
qdisc = new(QDisc, 1);
|
||||
if (!qdisc)
|
||||
|
||||
@@ -77,6 +77,8 @@ static int tclass_new(TClassKind kind, TClass **ret) {
|
||||
_cleanup_(tclass_unrefp) TClass *tclass = NULL;
|
||||
int r;
|
||||
|
||||
assert(ret);
|
||||
|
||||
if (kind == _TCLASS_KIND_INVALID) {
|
||||
tclass = new(TClass, 1);
|
||||
if (!tclass)
|
||||
|
||||
Reference in New Issue
Block a user