From bde7e12255a82f9b714fb3e44c291a79f7647cc9 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 11 Oct 2023 11:09:09 +0200 Subject: [PATCH] limits-util: suppress noisy debug message when reading tasks in top-level cgroup We have the "tasks.max" cgroup attribute only if we run in a cgroup namespace, but not on the host. Hence let's handle ENODATA silently simply to reduce the debug noise generated. --- src/basic/limits-util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/basic/limits-util.c b/src/basic/limits-util.c index dc0a2a6c94..9597c4c41c 100644 --- a/src/basic/limits-util.c +++ b/src/basic/limits-util.c @@ -156,8 +156,11 @@ uint64_t system_tasks_max(void) { if (r < 0) log_debug_errno(r, "Failed to determine cgroup root path, ignoring: %m"); else { + /* We'll have the "pids.max" attribute on the our root cgroup only if we are in a + * CLONE_NEWCGROUP namespace. On the top-level namespace this attribute is missing, hence + * suppress any message about that */ r = cg_get_attribute_as_uint64("pids", root, "pids.max", &c); - if (r < 0) + if (r < 0 && r != -ENODATA) log_debug_errno(r, "Failed to read pids.max attribute of root cgroup, ignoring: %m"); }