Fixes for claude review report (#42152)
This commit is contained in:
@@ -123,19 +123,20 @@ static int property_get_cpu_affinity(
|
||||
_cleanup_(cpu_set_done) CPUSet s = {};
|
||||
_cleanup_free_ uint8_t *array = NULL;
|
||||
size_t allocated;
|
||||
int r;
|
||||
|
||||
assert(bus);
|
||||
assert(reply);
|
||||
|
||||
if (c->cpu_affinity_from_numa) {
|
||||
int r;
|
||||
|
||||
r = numa_to_cpu_set(&c->numa_policy, &s);
|
||||
if (r < 0)
|
||||
return r;
|
||||
}
|
||||
|
||||
(void) cpu_set_to_dbus(c->cpu_affinity_from_numa ? &s : &c->cpu_set, &array, &allocated);
|
||||
r = cpu_set_to_dbus(c->cpu_affinity_from_numa ? &s : &c->cpu_set, &array, &allocated);
|
||||
if (r < 0)
|
||||
return r;
|
||||
|
||||
return sd_bus_message_append_array(reply, 'y', array, allocated);
|
||||
}
|
||||
|
||||
@@ -5119,6 +5119,7 @@ static int manager_dispatch_pidref_transport_fd(sd_event_source *source, int fd,
|
||||
|
||||
if (n != sizeof(child_pid)) {
|
||||
log_warning("Got pidref message of unexpected size %zi (expected %zu), ignoring.", n, sizeof(child_pid));
|
||||
cmsg_close_all(&msghdr);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -5138,6 +5139,8 @@ static int manager_dispatch_pidref_transport_fd(sd_event_source *source, int fd,
|
||||
}
|
||||
}
|
||||
|
||||
/* From this point on, the fds are owned by our local variables. Call cmsg_close_all no more. */
|
||||
|
||||
/* Verify and set parent pidref. */
|
||||
if (!ucred || !pid_is_valid(ucred->pid)) {
|
||||
log_warning("Received pidref message without valid credentials. Ignoring.");
|
||||
|
||||
Reference in New Issue
Block a user