From c49c2477a441cc36904bec51926d05093ce398c6 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Tue, 13 May 2025 22:56:02 +0200 Subject: [PATCH] journalctl-show: report VARLINKERROR= Who knows, maybe one day we'd support spawning journalctl as varlink socket-activatable service, where this bit of info would help. --- src/journal/journalctl-show.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/journal/journalctl-show.c b/src/journal/journalctl-show.c index 20b39da62d..eac93b222d 100644 --- a/src/journal/journalctl-show.c +++ b/src/journal/journalctl-show.c @@ -350,8 +350,10 @@ static int on_synchronize_reply( assert(vl); - if (error_id) + if (error_id) { log_warning("Failed to synchronize on Journal, ignoring: %s", error_id); + (void) sd_notifyf(/* unset_environment= */ false, "VARLINKERROR=%s", error_id); + } r = show_and_fflush(c); if (r < 0) @@ -377,7 +379,7 @@ static int on_signal(sd_event_source *s, const struct signalfd_siginfo *si, void r = varlink_connect_journal(&vl); if (r < 0) { - log_error_errno(r, "Failed to connect to Journal Varlink IPC interface, ignoring: %m"); + log_error_errno(r, "Failed to connect to Journal Varlink IPC interface, skipping synchronization: %m"); goto finish; }