tree-wide: no need to pass excess flags to open()/openat() if O_PATH is passed
As described in the documentation: When O_PATH is specified in flags, flag bits other than O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW are ignored. So, we can remove unnecessary flags in a case when O_PATH is passed to the open() or openat().
This commit is contained in:
@@ -613,7 +613,7 @@ static int path_set_perms(Item *i, const char *path) {
|
||||
* with AT_SYMLINK_NOFOLLOW, hence we emulate it here via
|
||||
* O_PATH. */
|
||||
|
||||
fd = open(path, O_RDONLY|O_NOFOLLOW|O_CLOEXEC|O_PATH|O_NOATIME);
|
||||
fd = open(path, O_NOFOLLOW|O_CLOEXEC|O_PATH);
|
||||
if (fd < 0)
|
||||
return log_error_errno(errno, "Adjusting owner and mode for %s failed: %m", path);
|
||||
|
||||
@@ -804,7 +804,7 @@ static int path_set_acls(Item *item, const char *path) {
|
||||
assert(item);
|
||||
assert(path);
|
||||
|
||||
fd = open(path, O_RDONLY|O_NOFOLLOW|O_CLOEXEC|O_PATH|O_NOATIME);
|
||||
fd = open(path, O_NOFOLLOW|O_CLOEXEC|O_PATH);
|
||||
if (fd < 0)
|
||||
return log_error_errno(errno, "Adjusting ACL of %s failed: %m", path);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user