From d709b92ef14e3e8c5c831c296cfbe1e6fc5202de Mon Sep 17 00:00:00 2001 From: Jan Macku Date: Tue, 7 Feb 2023 15:39:37 +0100 Subject: [PATCH 1/2] ci: fix missing quotes in `labeler.yml` --- .github/workflows/labeler.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index b6f65afd4e..bab6da7edd 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -97,7 +97,7 @@ jobs: "needs-discussion 🤔", "needs-reporter-feedback ❓", "dont-merge", - "squash-on-merge, + "squash-on-merge", "quick-review"]) { try { await github.rest.issues.removeLabel({ From de95bb2a98de9de3b18365122165ac4ac425fcbd Mon Sep 17 00:00:00 2001 From: Jan Macku Date: Tue, 7 Feb 2023 15:40:47 +0100 Subject: [PATCH 2/2] ci: remove `if: github.event.issue.pull_request` from `labeler.yml` `github.event.issue.pull_request` is an object, not a boolean. This is the root cause of why the step that is supposed to remove labels is always skipped. Having this condition in place is not necessary since the workflow is run on the `pull_request_target` event. --- .github/workflows/labeler.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index bab6da7edd..c282df8d73 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -83,7 +83,7 @@ jobs: }) - uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 - if: github.event_name == 'pull_request_target' && github.event.action == 'closed' && github.event.issue.pull_request + if: github.event_name == 'pull_request_target' && github.event.action == 'closed' with: script: | for (const label of ["please-review",