SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

everywhere: always use O_CLOEXEC where it makes sense

Browse Source
This commit is contained in:
Lennart Poettering
2014-02-13 14:59:56 +01:00
parent 955d98c9c1
commit c8a202b7d4
14 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bootchart/bootchart.c
+4 -4
View File
@@ -259,7 +259,7 @@ static void do_journal_append(char *file) {
memcpy(p, "BOOTCHART=", 10);
f = open(file, O_RDONLY);
f = open(file, O_RDONLY|O_CLOEXEC);
if (f < 0) {
log_error("Failed to read bootchart data: %m");
return;
@@ -356,11 +356,11 @@ int main(int argc, char *argv[]) {
t = time(NULL);
strftime(datestr, sizeof(datestr), "%Y%m%d-%H%M", localtime(&t));
snprintf(output_file, PATH_MAX, "%s/bootchart-%s.svg", arg_output_path, datestr);
of = fopen(output_file, "w");
of = fopen(output_file, "we");
}
if (sysfd < 0)
sysfd = open("/sys", O_RDONLY);
sysfd = open("/sys", O_RDONLY|O_CLOEXEC);
if (!build)
parse_env_file("/etc/os-release", NEWLINE,
@@ -424,7 +424,7 @@ int main(int argc, char *argv[]) {
t = time(NULL);
strftime(datestr, sizeof(datestr), "%Y%m%d-%H%M", localtime(&t));
snprintf(output_file, PATH_MAX, "%s/bootchart-%s.svg", arg_output_path, datestr);
of = fopen(output_file, "w");
of = fopen(output_file, "we");
}
if (!of) {
src/bootchart/store.c
+1 -1
View File
@@ -61,7 +61,7 @@ void log_uptime(void) {
char str[32];
double uptime;
f = fopen("/proc/uptime", "r");
f = fopen("/proc/uptime", "re");
if (!f)
return;