Merge pull request #15956 from poettering/news-v246

start of a NEWS file for v246 and minor assorted fixes

src/fuzz/fuzz-xdg-desktop.c

@@ -30,8 +30,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
 
         assert_se(service = xdg_autostart_service_parse_desktop(name));
         assert_se(service->name = strdup("fuzz-xdg-desktop.service"));
-        if (service)
-                (void) xdg_autostart_service_generate_unit(service, tmpdir);
+        (void) xdg_autostart_service_generate_unit(service, tmpdir);
 
         return 0;
 }

src/libsystemd/libsystemd.sym

@@ -715,4 +715,6 @@ global:
 
         sd_path_lookup;
         sd_path_lookup_strv;
+
+        sd_notify_barrier;
 } LIBSYSTEMD_245;

src/udev/net/link-config.c

@@ -332,7 +332,9 @@ static int get_mac(sd_device *device, MACAddressPolicy policy, struct ether_addr
                 /* We require genuine randomness here, since we want to make sure we won't collide with other
                  * systems booting up at the very same time. We do allow RDRAND however, since this is not
                  * cryptographic key material. */
-                genuine_random_bytes(mac->ether_addr_octet, ETH_ALEN, RANDOM_ALLOW_RDRAND);
+                r = genuine_random_bytes(mac->ether_addr_octet, ETH_ALEN, RANDOM_ALLOW_RDRAND);
+                if (r < 0)
+                        return log_device_error_errno(device, r, "Failed to acquire random data to generate MAC: %m");
         } else {
                 uint64_t result;
 

src/xdg-autostart-generator/xdg-autostart-service.c

@@ -73,7 +73,6 @@ static int xdg_config_parse_bool(
                 void *userdata) {
 
         bool *b = data;
-        const char *value;
 
         assert(filename);
         assert(lvalue);
@@ -85,7 +84,7 @@ static int xdg_config_parse_bool(
         else if (streq(rvalue, "false"))
                 *b = false;
         else
-                return log_syntax(unit, LOG_ERR, filename, line, SYNTHETIC_ERRNO(EINVAL), "Invalid value for boolean: %s", value);
+                return log_syntax(unit, LOG_ERR, filename, line, SYNTHETIC_ERRNO(EINVAL), "Invalid value for boolean: %s", rvalue);
 
         return 0;
 }