From d0f67f257d62c51dcc2d48f15e3793ad16856b3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 14 Apr 2026 16:42:41 +0200 Subject: [PATCH] busctl: reorder option cases to match --help output Co-developed-by: Claude Opus 4.6 --- src/busctl/busctl.c | 70 ++++++++++++++++++++++----------------------- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/src/busctl/busctl.c b/src/busctl/busctl.c index a895c3fe91..1e6fb64e96 100644 --- a/src/busctl/busctl.c +++ b/src/busctl/busctl.c @@ -2220,12 +2220,34 @@ static int parse_argv(int argc, char *argv[]) { arg_full = true; break; + case ARG_SYSTEM: + arg_runtime_scope = RUNTIME_SCOPE_SYSTEM; + break; + case ARG_USER: arg_runtime_scope = RUNTIME_SCOPE_USER; break; - case ARG_SYSTEM: - arg_runtime_scope = RUNTIME_SCOPE_SYSTEM; + case 'H': + arg_transport = BUS_TRANSPORT_REMOTE; + arg_host = optarg; + break; + + case 'M': + r = parse_machine_argument(optarg, &arg_host, &arg_transport); + if (r < 0) + return r; + break; + + case 'C': + r = capsule_name_is_valid(optarg); + if (r < 0) + return log_error_errno(r, "Unable to validate capsule name '%s': %m", optarg); + if (r == 0) + return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Invalid capsule name: %s", optarg); + + arg_host = optarg; + arg_transport = BUS_TRANSPORT_CAPSULE; break; case ARG_ADDRESS: @@ -2272,28 +2294,6 @@ static int parse_argv(int argc, char *argv[]) { arg_list = true; break; - case 'H': - arg_transport = BUS_TRANSPORT_REMOTE; - arg_host = optarg; - break; - - case 'M': - r = parse_machine_argument(optarg, &arg_host, &arg_transport); - if (r < 0) - return r; - break; - - case 'C': - r = capsule_name_is_valid(optarg); - if (r < 0) - return log_error_errno(r, "Unable to validate capsule name '%s': %m", optarg); - if (r == 0) - return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Invalid capsule name: %s", optarg); - - arg_host = optarg; - arg_transport = BUS_TRANSPORT_CAPSULE; - break; - case 'q': arg_quiet = true; break; @@ -2302,6 +2302,17 @@ static int parse_argv(int argc, char *argv[]) { arg_verbose = true; break; + case ARG_JSON: + r = parse_json_argument(optarg, &arg_json_format_flags); + if (r <= 0) + return r; + + break; + + case 'j': + arg_json_format_flags = SD_JSON_FORMAT_PRETTY_AUTO|SD_JSON_FORMAT_COLOR_AUTO; + break; + case ARG_XML_INTERFACE: arg_xml_interface = true; break; @@ -2349,17 +2360,6 @@ static int parse_argv(int argc, char *argv[]) { return r; break; - case 'j': - arg_json_format_flags = SD_JSON_FORMAT_PRETTY_AUTO|SD_JSON_FORMAT_COLOR_AUTO; - break; - - case ARG_JSON: - r = parse_json_argument(optarg, &arg_json_format_flags); - if (r <= 0) - return r; - - break; - case ARG_DESTINATION: arg_destination = optarg; break;