Add macro for checking if some flags are set

This way we don't need to repeat the argument twice.
I didn't replace all instances. I think it's better to leave out:
- asserts
- comparisons like x & y == x, which are mathematically equivalent, but
  here we aren't checking if flags are set, but if the argument fits in the
  flags.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2018-06-04 11:50:44 +02:00
parent 00bfe67f6b
commit d94a24ca2e
12 changed files with 30 additions and 13 deletions
+1 -1
View File
@@ -81,7 +81,7 @@ static int fd_is_nonblock_pipe(int fd) {
if (flags < 0)
return -errno;
return (flags & O_NONBLOCK) == O_NONBLOCK ? FD_IS_NONBLOCKING_PIPE : FD_IS_BLOCKING_PIPE;
return FLAGS_SET(flags, O_NONBLOCK) ? FD_IS_NONBLOCKING_PIPE : FD_IS_BLOCKING_PIPE;
}
int copy_bytes_full(