From d9cd9b2a1d084963627ab5814cd5eb0734d10912 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Tue, 10 Mar 2026 19:56:09 +0100 Subject: [PATCH] ci: Update claude review prompt to insist on valid lines Hopefully fixes the failure in https://github.com/systemd/systemd/actions/runs/22904601370/job/66461528144. --- .github/workflows/claude-review.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/claude-review.yml b/.github/workflows/claude-review.yml index 4b2a0dc5d6..0f1a52a305 100644 --- a/.github/workflows/claude-review.yml +++ b/.github/workflows/claude-review.yml @@ -187,8 +187,10 @@ jobs: Each subagent must return a JSON array of issues: `[{"file": "path", "line": , "severity": "must-fix|suggestion|nit", "body": "..."}]` - `line` must be a line number from the NEW side of the diff (i.e. where the comment - should appear in the changed file after the patch is applied). + `line` must be a line number from the NEW side of the diff **that appears inside + a diff hunk** (i.e. a line that is shown in the patch output). GitHub's review + comment API rejects lines outside the diff context, so never reference lines + that are not visible in the patch. Each subagent MUST verify its findings before returning them: - For style/convention claims, check at least 3 existing examples in the codebase to confirm