siphash24: change result argument to uint64_t
Change the "out" parameter from uint8_t[8] to uint64_t. On architectures which enforce pointer alignment this fixes crashes when we previously cast an unaligned array to uint64_t*, and on others this should at least improve performance as the compiler now aligns these properly. This also simplifies the code in most cases by getting rid of typecasts. The only place which we can't change is struct duid's en.id, as that is _packed_ and public API, so we can't enforce alignment of the "id" field and have to use memcpy instead.
This commit is contained in:
@@ -165,7 +165,7 @@ static int hash_url(const char *url, char **ret) {
|
||||
|
||||
assert(url);
|
||||
|
||||
siphash24((uint8_t *) &h, url, strlen(url), k.bytes);
|
||||
siphash24(&h, url, strlen(url), k.bytes);
|
||||
if (asprintf(ret, "%"PRIx64, h) < 0)
|
||||
return -ENOMEM;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user