From e0360405299f0aea0be6f727aeaca2729d76ba64 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Sun, 23 Aug 2026 04:51:30 +0900 Subject: [PATCH] test-compress: extend buffer size Otherwise, random input cases are not tested: ``` /* test_compress_decompress_blob */ /* testing xz text blob compression/decompression */ Loaded shared library 'liblzma.so.5' via dlopen(). /* testing xz random blob compression/decompression */ compression failed: No buffer space available /* testing lz4 text blob compression/decompression */ Loaded shared library 'liblz4.so.1' via dlopen(). /* testing lz4 random blob compression/decompression */ compression failed: No buffer space available /* testing zstd text blob compression/decompression */ Loaded shared library 'libzstd.so.1' via dlopen(). /* testing zstd random blob compression/decompression */ compression failed: No buffer space available /* testing gzip text blob compression/decompression */ Loaded shared library 'libz.so.1' via dlopen(). /* testing gzip random blob compression/decompression */ compression failed: No buffer space available /* testing bzip2 text blob compression/decompression */ Loaded shared library 'libbz2.so.1' via dlopen(). /* testing bzip2 random blob compression/decompression */ compression failed: No buffer space available ``` --- src/test/test-compress.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/test/test-compress.c b/src/test/test-compress.c index 6e181c5b67..bfffcc4804 100644 --- a/src/test/test-compress.c +++ b/src/test/test-compress.c @@ -44,25 +44,18 @@ TEST(compress_decompress_blob) { for (size_t t = 0; t < 2; t++) { const char *input = t == 0 ? text : data; size_t input_len = t == 0 ? sizeof(text) : sizeof(data); - bool may_fail = t == 1; - char compressed[512]; + char compressed[sizeof(data) * 4]; size_t csize; _cleanup_free_ char *decompressed = NULL; - int r; log_info("/* testing %s %s blob compression/decompression */", label, input); - r = compress_blob(c, input, input_len, compressed, sizeof(compressed), &csize, -1); - if (r == -ENOBUFS) { - log_info_errno(r, "compression failed: %m"); - ASSERT_TRUE(may_fail); - } else { - ASSERT_OK(r); - ASSERT_OK_ZERO(decompress_blob(c, compressed, csize, (void **) &decompressed, &csize, 0)); - ASSERT_NOT_NULL(decompressed); - ASSERT_EQ(memcmp(decompressed, input, input_len), 0); - } + ASSERT_OK(compress_blob(c, input, input_len, compressed, sizeof(compressed), &csize, -1)); + + ASSERT_OK_ZERO(decompress_blob(c, compressed, csize, (void **) &decompressed, &csize, 0)); + ASSERT_NOT_NULL(decompressed); + ASSERT_EQ(memcmp(decompressed, input, input_len), 0); ASSERT_FAIL(decompress_blob(c, "garbage", 7, (void **) &decompressed, &csize, 0)); }