From 1f034000a5343c6580338b1b306307525df5f6bf Mon Sep 17 00:00:00 2001 From: Evgeny Vereshchagin Date: Thu, 21 May 2020 08:20:01 +0200 Subject: [PATCH 1/2] oss-fuzz: turn on the pointer-overflow check It's off by default on OSS-Fuzz but it should be safe to turn it on manually: https://github.com/google/oss-fuzz/issues/659#issuecomment-631897889 Just a follow-up to https://github.com/systemd/systemd/pull/15865. --- tools/oss-fuzz.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/oss-fuzz.sh b/tools/oss-fuzz.sh index 79846f8787..5b8690b687 100755 --- a/tools/oss-fuzz.sh +++ b/tools/oss-fuzz.sh @@ -27,9 +27,15 @@ build=$WORK/build rm -rf $build mkdir -p $build -fuzzflag="oss-fuzz=true" if [ -z "$FUZZING_ENGINE" ]; then fuzzflag="llvm-fuzz=true" +else + fuzzflag="oss-fuzz=true" + if [[ "$SANITIZER" == undefined ]]; then + UBSAN_FLAGS="-fsanitize=pointer-overflow -fno-sanitize-recover=pointer-overflow" + CFLAGS="$CFLAGS $UBSAN_FLAGS" + CXXFLAGS="$CXXFLAGS $UBSAN_FLAGS" + fi fi meson $build -D$fuzzflag -Db_lundef=false From 2f0a427b45369360846b22ddca5147d4b6e04b9a Mon Sep 17 00:00:00 2001 From: Evgeny Vereshchagin Date: Thu, 21 May 2020 09:00:53 +0200 Subject: [PATCH 2/2] docs: add a link to the Fossies codespell report --- docs/CODE_QUALITY.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/CODE_QUALITY.md b/docs/CODE_QUALITY.md index 9f261474ac..a724d663f6 100644 --- a/docs/CODE_QUALITY.md +++ b/docs/CODE_QUALITY.md @@ -71,5 +71,8 @@ available functionality: See [Testing systemd using sanitizers](https://systemd.io/TESTING_WITH_SANITIZERS) for more information. +16. Fossies provides [source code misspelling reports](https://fossies.org/features.html#codespell). + The systemd report can be found [here](https://fossies.org/linux/test/systemd-master.tar.gz/codespell.html). + Access to Coverity and oss-fuzz reports is limited. Please reach out to the maintainers if you need access.