SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

seccomp: default to something resembling the current personality when locking it

Browse Source 
Let's lock the personality to the currently set one, if nothing is
specifically specified. But do so with a grain of salt, and never
default to any exotic personality here, but only PER_LINUX or
PER_LINUX32.
This commit is contained in:
Lennart Poettering
2017-08-29 15:56:57 +02:00
parent 78e864e5b3
commit e8132d63fe
4 changed files with 66 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test-seccomp.c
+34 -4
View File
@@ -567,6 +567,7 @@ static void test_load_syscall_filter_set_raw(void) {
}
static void test_lock_personality(void) {
unsigned long current;
pid_t pid;
if (!is_seccomp_available())
@@ -574,26 +575,55 @@ static void test_lock_personality(void) {
if (geteuid() != 0)
return;
assert_se(opinionated_personality(&current) >= 0);
log_info("current personality=%lu", current);
pid = fork();
assert_se(pid >= 0);
if (pid == 0) {
assert_se(seccomp_lock_personality(PER_LINUX) >= 0);
assert_se(seccomp_lock_personality(current) >= 0);
assert_se(personality(PER_LINUX) == PER_LINUX);
assert_se((unsigned long) personality(current) == current);
errno = EUCLEAN;
assert_se(personality(PER_LINUX | ADDR_NO_RANDOMIZE) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_LINUX | MMAP_PAGE_ZERO) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_LINUX | ADDR_COMPAT_LAYOUT) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_LINUX | READ_IMPLIES_EXEC) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_LINUX_32BIT) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_SVR4) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_BSD) == -1 && errno == EPERM);
assert_se(personality(PER_LINUX32) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(current == PER_LINUX ? PER_LINUX32 : PER_LINUX) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_LINUX32_3GB) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PER_UW7) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(0x42) == -1 && errno == EPERM);
errno = EUCLEAN;
assert_se(personality(PERSONALITY_INVALID) == -1 && errno == EPERM); /* maybe remove this later */
assert_se(personality(PER_LINUX) == PER_LINUX);
assert_se((unsigned long) personality(current) == current);
_exit(EXIT_SUCCESS);
}