SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tree-wide: fix log messages using %m without an errno

Browse Source
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2025-11-18 12:27:59 +01:00
parent 4a3d57a47a
commit e8a7722eec
8 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/networkd-ipv4ll.c
+1 -1
View File
@@ -155,7 +155,7 @@ static void ipv4ll_handler(sd_ipv4ll *ll, int event, void *userdata) {
case SD_IPV4LL_EVENT_BIND:
r = ipv4ll_address_claimed(ll, link);
if (r < 0) {
log_link_error(link, "Failed to configure ipv4ll address: %m");
log_link_error_errno(link, r, "Failed to configure ipv4ll address: %m");
link_enter_failed(link);
return;
}
src/network/networkd-nexthop.c
+1 -1
View File
@@ -1123,7 +1123,7 @@ int manager_rtnl_process_nexthop(sd_netlink *rtnl, sd_netlink_message *message,
log_warning_errno(r, "rtnl: could not get NHA_ID attribute, ignoring: %m");
return 0;
} else if (id == 0) {
log_warning("rtnl: received nexthop message with invalid nexthop ID, ignoring: %m");
log_warning("rtnl: received nexthop message with invalid nexthop ID, ignoring.");
return 0;
}
src/network/networkd-wifi.c
+2 -2
View File
@@ -119,7 +119,7 @@ int manager_genl_process_nl80211_config(sd_netlink *genl, sd_netlink_message *me
}
if (!streq(ifname, link->ifname)) {
log_link_debug(link, "nl80211: received %s(%u) message with invalid interface name '%s', ignoring: %m",
log_link_debug(link, "nl80211: received %s(%u) message with invalid interface name '%s', ignoring.",
strna(nl80211_cmd_to_string(cmd)), cmd, ifname);
return 0;
}
@@ -139,7 +139,7 @@ int manager_genl_process_nl80211_config(sd_netlink *genl, sd_netlink_message *me
}
if (r >= 0) {
if (len == 0) {
log_link_debug(link, "nl80211: received SSID has zero length, ignoring it: %m");
log_link_debug(link, "nl80211: received SSID has zero length, ignoring it.");
ssid = mfree(ssid);
} else if (strlen_ptr(ssid) != len) {
log_link_debug(link, "nl80211: received SSID contains NUL characters, ignoring it.");
src/network/networkd-wiphy.c
+4 -6
View File
@@ -409,8 +409,7 @@ int manager_genl_process_nl80211_wiphy(sd_netlink *genl, sd_netlink_message *mes
(void) wiphy_get_by_index(manager, index, &w);
switch (cmd) {
case NL80211_CMD_NEW_WIPHY: {
case NL80211_CMD_NEW_WIPHY:
if (!w) {
r = wiphy_new(manager, message, &w);
if (r < 0) {
@@ -432,11 +431,10 @@ int manager_genl_process_nl80211_wiphy(sd_netlink *genl, sd_netlink_message *mes
log_wiphy_warning_errno(w, r, "Failed to update wiphy, ignoring: %m");
break;
}
case NL80211_CMD_DEL_WIPHY:
case NL80211_CMD_DEL_WIPHY:
if (!w) {
log_debug("The kernel removes wiphy we do not know, ignoring: %m");
log_debug("The kernel removed wiphy we do not know, ignoring.");
return 0;
}
@@ -445,7 +443,7 @@ int manager_genl_process_nl80211_wiphy(sd_netlink *genl, sd_netlink_message *mes
break;
default:
log_wiphy_debug(w, "nl80211: received %s(%u) message.",
log_wiphy_debug(w, "nl80211: received %s(%u) message, ignoring.",
strna(nl80211_cmd_to_string(cmd)), cmd);
}