SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tree-wide: voidify pager_open()

Browse Source 
Even if pager_open() fails, in general, we should continue the operations.
All erroneous cases in pager_open() show log message in the function.
So, it is not necessary to check the returned value.
This commit is contained in:
Yu Watanabe
2018-03-19 21:04:02 +09:00
parent 24fcd009c3
commit ee5324aa04
15 changed files with 57 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/machine/machinectl.c
+6 -6
View File
@@ -207,7 +207,7 @@ static int list_machines(int argc, char *argv[], void *userdata) {
assert(bus);
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
r = sd_bus_call_method(bus,
"org.freedesktop.machine1",
@@ -363,7 +363,7 @@ static int list_images(int argc, char *argv[], void *userdata) {
assert(bus);
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
r = sd_bus_call_method(bus,
"org.freedesktop.machine1",
@@ -860,7 +860,7 @@ static int show_machine(int argc, char *argv[], void *userdata) {
properties = !strstr(argv[0], "status");
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
if (properties && argc <= 1) {
@@ -1213,7 +1213,7 @@ static int show_image(int argc, char *argv[], void *userdata) {
properties = !strstr(argv[0], "status");
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
if (argc <= 1) {
@@ -2543,7 +2543,7 @@ static int list_transfers(int argc, char *argv[], void *userdata) {
double progress;
int r;
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
r = sd_bus_call_method(bus,
"org.freedesktop.import1",
@@ -2758,7 +2758,7 @@ static int clean_images(int argc, char *argv[], void *userdata) {
}
static int help(int argc, char *argv[], void *userdata) {
pager_open(arg_no_pager, false);
(void) pager_open(arg_no_pager, false);
printf("%s [OPTIONS...] {COMMAND} ...\n\n"
"Send control commands to or query the virtual machine and container\n"