basic/user-util: modernize getgroups_alloc() a bit

- Make sure ret is initialized if we return >= 0 - Reduce variable scope
2024-12-10 20:51:14 +01:00
parent 8112df6bef
commit f0e8db76ca
3 changed files with 20 additions and 23 deletions
@@ -444,9 +444,8 @@ TEST(gid_lists_ops) {
        assert_se(nresult >= 0);
        assert_se(memcmp_nn(result2, ELEMENTSOF(result2), res4, nresult) == 0);

-        nresult = getgroups_alloc(&gids);
-        assert_se(nresult >= 0 || nresult == -EINVAL || nresult == -ENOMEM);
-        assert_se(gids);
+        ASSERT_OK(nresult = getgroups_alloc(&gids));
+        assert_se(gids || nresult == 0);
 }

 TEST(parse_uid_range) {