From 47398ea70531fce95ca084e8e023e69ea24dc074 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 26 Nov 2021 00:09:30 +0900 Subject: [PATCH 1/2] homework: drop unnecessary initialization --- src/home/homework-password-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/home/homework-password-cache.c b/src/home/homework-password-cache.c index c1606c5f5f..1133ab24b8 100644 --- a/src/home/homework-password-cache.c +++ b/src/home/homework-password-cache.c @@ -16,7 +16,7 @@ void password_cache_free(PasswordCache *cache) { void password_cache_load_keyring(UserRecord *h, PasswordCache *cache) { _cleanup_(erase_and_freep) void *p = NULL; _cleanup_free_ char *name = NULL; - char **strv = NULL; + char **strv; key_serial_t serial; size_t sz; int r; From 5601a9b91047a424245243c61c7af07884dbf360 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 26 Nov 2021 00:14:29 +0900 Subject: [PATCH 2/2] homework: fix memleak Fixes #21521. --- src/home/homework-password-cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/home/homework-password-cache.c b/src/home/homework-password-cache.c index 1133ab24b8..00a0f69bc9 100644 --- a/src/home/homework-password-cache.c +++ b/src/home/homework-password-cache.c @@ -11,6 +11,7 @@ void password_cache_free(PasswordCache *cache) { cache->pkcs11_passwords = strv_free_erase(cache->pkcs11_passwords); cache->fido2_passwords = strv_free_erase(cache->fido2_passwords); + cache->keyring_passswords = strv_free_erase(cache->keyring_passswords); } void password_cache_load_keyring(UserRecord *h, PasswordCache *cache) {