diff --git a/src/fundamental/memory-util-fundamental.c b/src/fundamental/memory-util-fundamental.c index 02b55251fd..1a64fbe514 100644 --- a/src/fundamental/memory-util-fundamental.c +++ b/src/fundamental/memory-util-fundamental.c @@ -3,6 +3,8 @@ #include "memory-util-fundamental.h" bool memeqbyte(uint8_t byte, const void *data, size_t length) { + assert(data || length == 0); + /* Does the buffer consist entirely of the same specific byte value? * Copied from https://github.com/systemd/casync/, copied in turn from * https://github.com/rustyrussell/ccan/blob/master/ccan/mem/mem.c#L92, @@ -12,12 +14,12 @@ bool memeqbyte(uint8_t byte, const void *data, size_t length) { const uint8_t *p = data; /* Check first 16 bytes manually */ - for (size_t i = 0; i < 16; i++, length--) { - if (length == 0) - return true; + for (size_t i = 0; i < 16 && length > 0; i++, length--) if (p[i] != byte) return false; - } + + if (length == 0) + return true; /* Now we know first 16 bytes match, memcmp() with self. */ return memcmp(data, p + 16, length) == 0;