tree-wide: check if errno is greater then zero
gcc is confused by the common idiom of
return errno ? -errno : -ESOMETHING
and thinks a positive value may be returned. Replace this condition
with errno > 0 to help gcc and avoid many spurious warnings. I filed
a gcc rfe a long time ago, but it hard to say if it will ever be
implemented [1].
Both conventions were used in the codebase, this change makes things
more consistent. This is a follow up to bcb161b023.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61846
This commit is contained in:
@@ -280,7 +280,7 @@ static int putgrent_with_members(const struct group *gr, FILE *group) {
|
||||
|
||||
errno = 0;
|
||||
if (putgrent(&t, group) != 0)
|
||||
return errno ? -errno : -EIO;
|
||||
return errno > 0 ? -errno : -EIO;
|
||||
|
||||
return 1;
|
||||
}
|
||||
@@ -288,7 +288,7 @@ static int putgrent_with_members(const struct group *gr, FILE *group) {
|
||||
|
||||
errno = 0;
|
||||
if (putgrent(gr, group) != 0)
|
||||
return errno ? -errno : -EIO;
|
||||
return errno > 0 ? -errno : -EIO;
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -330,7 +330,7 @@ static int putsgent_with_members(const struct sgrp *sg, FILE *gshadow) {
|
||||
|
||||
errno = 0;
|
||||
if (putsgent(&t, gshadow) != 0)
|
||||
return errno ? -errno : -EIO;
|
||||
return errno > 0 ? -errno : -EIO;
|
||||
|
||||
return 1;
|
||||
}
|
||||
@@ -338,7 +338,7 @@ static int putsgent_with_members(const struct sgrp *sg, FILE *gshadow) {
|
||||
|
||||
errno = 0;
|
||||
if (putsgent(sg, gshadow) != 0)
|
||||
return errno ? -errno : -EIO;
|
||||
return errno > 0 ? -errno : -EIO;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user