treewide: yet more log_*_errno + return simplifications
Using:
find . -name '*.[ch]' | while read f; do perl -i.mmm -e \
'local $/;
local $_=<>;
s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg;
print;'
$f
done
And a couple of manual whitespace fixups.
This commit is contained in:
@@ -720,31 +720,23 @@ int manager_connect_bus(Manager *m) {
|
||||
log_debug_errno(r, "Failed to connect to bus, trying again in 5s: %m");
|
||||
|
||||
r = sd_event_add_time(m->event, &m->bus_retry_event_source, CLOCK_MONOTONIC, now(CLOCK_MONOTONIC) + 5*USEC_PER_SEC, 0, on_bus_retry, m);
|
||||
if (r < 0) {
|
||||
log_error_errno(r, "Failed to install bus reconnect time event: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_error_errno(r, "Failed to install bus reconnect time event: %m");
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
r = sd_bus_add_object_vtable(m->bus, NULL, "/org/freedesktop/resolve1", "org.freedesktop.resolve1.Manager", resolve_vtable, m);
|
||||
if (r < 0) {
|
||||
log_error_errno(r, "Failed to register object: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_error_errno(r, "Failed to register object: %m");
|
||||
|
||||
r = sd_bus_request_name(m->bus, "org.freedesktop.resolve1", 0);
|
||||
if (r < 0) {
|
||||
log_error_errno(r, "Failed to register name: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_error_errno(r, "Failed to register name: %m");
|
||||
|
||||
r = sd_bus_attach_event(m->bus, m->event, 0);
|
||||
if (r < 0) {
|
||||
log_error_errno(r, "Failed to attach bus to event loop: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_error_errno(r, "Failed to attach bus to event loop: %m");
|
||||
|
||||
r = sd_bus_add_match(m->bus, &m->prepare_for_sleep_slot,
|
||||
"type='signal',"
|
||||
|
||||
@@ -721,10 +721,8 @@ int dns_scope_notify_conflict(DnsScope *scope, DnsResourceRecord *rr) {
|
||||
r = ordered_hashmap_put(scope->conflict_queue, rr->key, rr);
|
||||
if (r == -EEXIST || r == 0)
|
||||
return 0;
|
||||
if (r < 0) {
|
||||
log_debug_errno(r, "Failed to queue conflicting RR: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_debug_errno(r, "Failed to queue conflicting RR: %m");
|
||||
|
||||
dns_resource_record_ref(rr);
|
||||
|
||||
@@ -740,10 +738,8 @@ int dns_scope_notify_conflict(DnsScope *scope, DnsResourceRecord *rr) {
|
||||
now(clock_boottime_or_monotonic()) + jitter,
|
||||
LLMNR_JITTER_INTERVAL_USEC,
|
||||
on_conflict_dispatch, scope);
|
||||
if (r < 0) {
|
||||
log_debug_errno(r, "Failed to add conflict dispatch event: %m");
|
||||
return r;
|
||||
}
|
||||
if (r < 0)
|
||||
return log_debug_errno(r, "Failed to add conflict dispatch event: %m");
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user