Yu Watanabe
172cbcdc8b
tree-wide: fix typo
2022-06-15 14:50:34 +09:00
Yu Watanabe
6243063824
test: use trap RETURN
2022-06-14 21:08:04 +09:00
Yu Watanabe
2f34ee3329
test: insert space in for loop
2022-06-14 21:05:10 +09:00
Yu Watanabe
47ba157cc0
test: import localed tests from debian/ubuntu test suite
2022-06-14 20:59:36 +09:00
Yu Watanabe
39f4546199
test: import hostnamed tests from debian/ubuntu test suite
2022-06-14 20:56:18 +09:00
Yu Watanabe
aab61a8c99
test: support debian/ubuntu specific timezone config file
2022-06-14 20:52:44 +09:00
Yu Watanabe
8ed2103306
test: drop unnecessary --no-pager option
2022-06-14 20:52:44 +09:00
Yu Watanabe
d170b47535
test: introduce assert_not_in() helper function
...
This also silence assertions, and replace grep with bash's regular
expression match.
2022-06-14 20:52:38 +09:00
Frantisek Sumsal
bf24eafcd2
Merge pull request #23584 from yuwata/test-login
...
test: import logind test from debian/ubuntu test suite
2022-06-10 14:50:35 +00:00
Yu Watanabe
759ed0a253
test: import timedated test from debian/ubuntu test suite
2022-06-10 16:04:52 +09:00
Yu Watanabe
9c94ab0f6f
test: import logind test from debian/ubuntu test suite
2022-06-10 15:44:10 +09:00
Frantisek Sumsal
47d81bc613
test: fix TEST-70 under sanitizers
...
Addresses:
* https://github.com/systemd/systemd/issues/23578#issuecomment-1144089821
* https://github.com/systemd/systemd-centos-ci/pull/496#issuecomment-1144640305
2022-06-06 14:48:27 +02:00
Yu Watanabe
71891fb2de
Merge pull request #23558 from msekletar/issue-20329-followup
...
Actually delay running of mount start jobs when /p/s/mountinfo is rate limited
2022-05-31 17:38:25 +09:00
Frantisek Sumsal
eec21613bb
test: add coverage for #23481
...
Provide some coverage for systemd/systemd#23481.
Without 794da5a#0 0x7fdf9c8b0f8c in reallocarray (/lib64/libasan.so.6+0xaef8c)
[ 34.879554] testsuite-29.sh[1383]: #1 0x7fdf9b4270f5 in unit_file_changes_add ../src/shared/install.c:282
[ 34.879926] testsuite-29.sh[1383]: #2 0x7fdf9b2ad9e5 in bus_deserialize_and_dump_unit_file_changes ../src/shared/bus-unit-util.c:2688
[ 34.880267] testsuite-29.sh[1383]: #3 0x40bc27 in maybe_enable_disable ../src/portable/portablectl.c:582
[ 34.880673] testsuite-29.sh[1383]: #4 0x40ef56 in maybe_stop_disable ../src/portable/portablectl.c:810
[ 34.881064] testsuite-29.sh[1383]: #5 0x410bc2 in detach_image ../src/portable/portablectl.c:924
[ 34.881493] testsuite-29.sh[1383]: #6 0x7fdf9b5df424 in dispatch_verb ../src/shared/verbs.c:103
[ 34.881953] testsuite-29.sh[1383]: #7 0x41604a in run ../src/portable/portablectl.c:1427
[ 34.882459] testsuite-29.sh[1383]: #8 0x416106 in main ../src/portable/portablectl.c:1430
[ 34.882947] testsuite-29.sh[1383]: #9 0x7fdf99d5de8f in __libc_start_call_main (/lib64/libc.so.6+0x44e8f)
[ 34.883368] testsuite-29.sh[1383]: Indirect leak of 104 byte(s) in 2 object(s) allocated from:
[ 34.883732] testsuite-29.sh[1383]: #0 0x7fdf9c85b8f7 in strdup (/lib64/libasan.so.6+0x598f7)
[ 34.884089] testsuite-29.sh[1383]: #1 0x7fdf9b4271aa in unit_file_changes_add ../src/shared/install.c:288
[ 34.884508] testsuite-29.sh[1383]: #2 0x7fdf9b2ad9e5 in bus_deserialize_and_dump_unit_file_changes ../src/shared/bus-unit-util.c:2688
[ 34.884926] testsuite-29.sh[1383]: #3 0x40bc27 in maybe_enable_disable ../src/portable/portablectl.c:582
[ 34.885307] testsuite-29.sh[1383]: #4 0x40ef56 in maybe_stop_disable ../src/portable/portablectl.c:810
[ 34.885647] testsuite-29.sh[1383]: #5 0x410bc2 in detach_image ../src/portable/portablectl.c:924
[ 34.885987] testsuite-29.sh[1383]: #6 0x7fdf9b5df424 in dispatch_verb ../src/shared/verbs.c:103
[ 34.886271] testsuite-29.sh[1383]: #7 0x41604a in run ../src/portable/portablectl.c:1427
[ 34.886557] testsuite-29.sh[1383]: #8 0x416106 in main ../src/portable/portablectl.c:1430
[ 34.886892] testsuite-29.sh[1383]: #9 0x7fdf99d5de8f in __libc_start_call_main (/lib64/libc.so.6+0x44e8f)
[ 34.887187] testsuite-29.sh[1383]: Indirect leak of 2 byte(s) in 2 object(s) allocated from:
[ 34.887520] testsuite-29.sh[1383]: #0 0x7fdf9c85b8f7 in strdup (/lib64/libasan.so.6+0x598f7)
[ 34.887797] testsuite-29.sh[1383]: #1 0x7fdf9b427249 in unit_file_changes_add ../src/shared/install.c:296
[ 34.888117] testsuite-29.sh[1383]: #2 0x7fdf9b2ad9e5 in bus_deserialize_and_dump_unit_file_changes ../src/shared/bus-unit-util.c:2688
[ 34.888434] testsuite-29.sh[1383]: #3 0x40bc27 in maybe_enable_disable ../src/portable/portablectl.c:582
[ 34.888693] testsuite-29.sh[1383]: #4 0x40ef56 in maybe_stop_disable ../src/portable/portablectl.c:810
[ 34.888990] testsuite-29.sh[1383]: #5 0x410bc2 in detach_image ../src/portable/portablectl.c:924
[ 34.889254] testsuite-29.sh[1383]: #6 0x7fdf9b5df424 in dispatch_verb ../src/shared/verbs.c:103
[ 34.889580] testsuite-29.sh[1383]: #7 0x41604a in run ../src/portable/portablectl.c:1427
[ 34.889877] testsuite-29.sh[1383]: #8 0x416106 in main ../src/portable/portablectl.c:1430
[ 34.890193] testsuite-29.sh[1383]: #9 0x7fdf99d5de8f in __libc_start_call_main (/lib64/libc.so.6+0x44e8f)
[ 34.890482] testsuite-29.sh[1383]: SUMMARY: AddressSanitizer: 154 byte(s) leaked in 6 allocation(s).
```
With 794da5a
2022-05-31 01:09:53 +09:00
Michal Sekletar
9e15be6c8d
tests: make sure we delay running mount start jobs when /p/s/mountinfo is rate limited
2022-05-30 14:50:05 +02:00
Yu Watanabe
1f97c2da0c
test: add test for bus introspection of portable1
...
Follow-up for #23454 .
2022-05-21 06:31:19 +09:00
Luca Boccassi
7b2e763242
portable: reject root directories without an ID field in os-release
...
We always require at least ID to be set in os-release, reject
and propagate error to the caller instead of asserting later
2022-05-20 13:08:45 +01:00
Zbigniew Jędrzejewski-Szmek
d7ff524039
tree-wide: drop manually-crafted message for missing variables
...
Bash will generate a very nice message for us:
/tmp/ff.sh: line 1: SOMEVAR: parameter null or not set
Let's save some keystrokes by not replacing this with our own inferior
messages.
2022-05-04 20:53:46 +09:00
Lennart Poettering
41be3b099f
Merge pull request #23170 from poettering/creds-copy
...
import system credentials from sd-stub + qemu fw_cfg + kernel cmdline explicitly in PID 1
2022-05-02 16:32:21 +02:00
Luca Boccassi
6a59dfa108
analyze security: print DeviceAllow list
...
Many sandboxing options add implicit DeviceAllow rules, which might be confusing
for users running systemd-analyze security and not expecting it.
Print the list.
Fixes https://github.com/systemd/systemd/issues/23185
2022-05-01 13:43:01 +09:00
Luca Boccassi
444d9abd06
analyze: fix crash with online security check
...
1449b0f8a9https://github.com/systemd/systemd/issues/23224
2022-05-01 11:47:44 +09:00
Lennart Poettering
93a1f57db8
test: test new credential features
2022-04-28 18:12:00 +02:00
Frantisek Sumsal
98f8c31638
test: extend the "hashed" unit names coverage a bit
...
Follow-up to #22759 .
2022-04-23 08:45:25 +09:00
Lennart Poettering
42a3f23cc1
test: also test nspawn system→service inheritance of creds
2022-04-22 11:32:47 +02:00
Lennart Poettering
6d085447fa
test: make sure that SetCredential=/LoadCredential fallback won#t regress
2022-04-22 11:32:47 +02:00
Luca Boccassi
3603f15171
nspawn: fix --ephemeral with --machine
...
Follow-up for https://github.com/systemd/systemd/commit/2362fdde1bd4bf54772383ef29431f683729ba76
When --machine is specified with --ephemeral, no random suffix is added, so
the recently added assert would fail.
Add a top-level variable with the expected file name for nspawn files, and
compute it when the rest of the names are computed.
2022-04-20 02:33:01 +09:00
Luca Boccassi
2362fdde1b
nspawn: fix locating config files with --ephemeral
...
When --ephemeral is used, a random 16 characters suffix is added to the image
name, so matching on .nspawn files based on the image name no longer works.
Fixes https://github.com/systemd/systemd/issues/13297
2022-04-19 06:17:16 +09:00
Frantisek Sumsal
18161cf0ca
test: partition the MD device
...
Also, loop the assemble/disassemble part couple of times to test udev
even harder.
Resolves : #23092
2022-04-17 21:53:12 +09:00
Frantisek Sumsal
6d49e0945f
test: cleanup after the MD + LVM test case as well
2022-04-17 16:14:30 +09:00
Yu Watanabe
7be87278a3
Merge pull request #23021 from fbuihuu/tmpfiles-fix-precedence-with-plus-sign
...
Tmpfiles fix precedence with plus sign
2022-04-16 01:36:51 +09:00
Frantisek Sumsal
d3ce9bed68
test: add a test case for MD + LVM + ext4
2022-04-14 12:54:16 +02:00
Frantisek Sumsal
1bb3887595
test: extend testcase_mdadm_basic() with RAID 5 and 10
2022-04-14 12:45:23 +02:00
Lennart Poettering
4bcf5c11c8
Merge pull request #23011 from mrc0mmand/TEST-64-md
...
test: add MD-related tests to TEST-64
2022-04-13 22:26:50 +02:00
Michal Sekletar
b26f4f0028
tests: reflect that we can now handle devices with very long sysfs paths
2022-04-13 17:46:52 +02:00
Frantisek Sumsal
3c9af05cae
test: add MD-related tests to TEST-64
2022-04-14 00:12:02 +09:00
Franck Bui
402f2b3ce8
test: add test checking tmpfiles conf file precedence
2022-04-11 11:22:39 +02:00
Franck Bui
9f55d48ba5
test tmpfiles: add a test for 'w+'
2022-04-11 11:22:39 +02:00
Michal Sekletar
2ef0101e0b
tests: add test case for long unit names
2022-04-08 15:18:29 +02:00
Luca Boccassi
cedf5b1aef
core: fix dm-verity auto-discovery in MountImageUnit()
...
The implementation of MountImageUnit()/systemctl mount-image was
changed to use a /proc/self/fd path as the source, but that causes
the dm-verity files autodiscovery to fail, as it looks for files
in the same directory as the image.
Use the original file path when setting up dm-verity.
2022-04-07 17:31:04 +01:00
Yu Watanabe
70a3ce51f3
test: drop unnecessary use of loop device
...
To avoid inferences with udevd.
2022-04-07 01:44:39 +09:00
Yu Watanabe
bc6bd62c0e
test: use udevadm lock when partitioning block devices
...
We can use `sfdisk --lock` for these cases, but some CI environments
have old sfdisk which does not support `--lock` option.
2022-04-07 01:42:44 +09:00
Yu Watanabe
3452ae90ea
test: --initialized=yes is the default for udevadm wait
2022-04-07 00:40:33 +09:00
Yu Watanabe
14f9c81fb4
test: use udevadm wait and lock
...
Hopefully fixes #22911 .
2022-04-05 05:00:39 +09:00
Frantisek Sumsal
c189d3bd78
test: use the new udevadm wait verb to wait for the loop device
...
The original workaround didn't work, as `systemd-repart` kept failing
even when the `/dev/loopX` device was present:
```
[ 13.959419] H testsuite-58.sh[280]: + LOOP=/dev/loop1
[ 13.959636] H testsuite-58.sh[280]: + :
[ 13.959764] H testsuite-58.sh[280]: + test -e /dev/loop1
[ 13.959895] H testsuite-58.sh[280]: + break
[ 13.960023] H testsuite-58.sh[280]: + systemd-repart --pretty=yes --definitions=/tmp/testsuite-58-sector/ --seed=750b6cd5c4ae4012a15e7be3c29e6a47 --empty=require --dry-run=no /dev/loop1
[ 13.970538] H testsuite-58.sh[363]: Device '/dev/loop1' has no dm-crypt/dm-verity device, no need to look for underlying block device.
[ 13.970538] H testsuite-58.sh[363]: Failed to determine canonical path for '/dev/loop1': No such file or directory
[ 13.970538] H testsuite-58.sh[363]: Failed to open file or determine backing device of /dev/loop1: No such file or directory
```
2022-04-04 15:58:03 +02:00
Yu Watanabe
37ebfe49de
Merge pull request #22926 from bluca/analyze_offline_filter
...
analyze: fix offline checks for syscall filter and 'native' architecture
2022-04-01 23:43:18 +09:00
Luca Boccassi
1449b0f8a9
analyze: fix offline check for 'native' syscall architecture
...
Enum values are stored in the set, not strings
2022-04-01 10:42:48 +01:00
Yu Watanabe
e529abe24d
test: replace helper_wait_for_dev() with 'udevadm wait'
2022-04-01 15:13:18 +09:00
Yu Watanabe
10176f0011
test: add tests for worker error code
2022-03-30 01:27:29 +09:00
Luca Boccassi
2350712e32
portable: allow reattaching when one image has a version and the other does not
...
A reattach might go from img.raw to img_0.1.raw or viceversa, but this is
not allowed right now as we try to match the full name.
Also take into account that running strcspn(a, '/') on an image name, without
leading path, will return the length of the full string, but the versions
might be different so they won't match, eg:
img_0.1.raw -> 12
img_0.1.1.raw -> 14
So adjust the check to take that into account, and skip it if we are not
dealing with directories
2022-03-29 14:02:48 +01:00
Frantisek Sumsal
41d1aaea64
test: use flock when calling mkfs.btrfs
...
As stated in https://github.com/systemd/systemd/issues/21819#issuecomment-1064377645
`mkfs.btrfs` doesn't hold the lock for the whole duration of
`mkfs.btrfs`, thus causing unexpected races & test fails. Let's
wrap the `mkfs.btrfs` calls in an flock wrapper to mitigate this.
Hopefully fixes : #21819
2022-03-25 10:28:07 +09:00
Yu Watanabe
Frantisek Sumsal
Michal Sekletar
Luca Boccassi
Zbigniew Jędrzejewski-Szmek
Lennart Poettering
Franck Bui