Commit Graph
91276 Commits
Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek 388eb27018 sysctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Commands" option group is added
so that the section heading stays the same. The abstract is changed to the
imperative. --help now goes through the pager, like other commands with
--no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek ae6f195d63 storagectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager. The mount.storage helper interface is described
by a second COMMAND(), so that it is exposed by --introspect-cli too.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 3a2d587313 run: convert to VERB_COMMAND and add --introspect-cli
The custom help() and help_sudo_mode() are replaced by COMMAND()
descriptions for systemd-run and run0, and --introspect-cli is added to
both. run0 --help now goes through the pager, like systemd-run --help.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek be5ae9fb40 repart: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 19a24f926d pcrlock: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek bf08fc692a nspawn: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The generic options at the top now get an
"Options" heading like the other groups.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek a9f42ed015 mstack: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The "Commands" option group is moved before the
other options and an explicit "Options" group is added, so that the sections
are printed in the same order as before. --help now goes through the pager,
like other commands with --no-pager. The mount.mstack helper interface is
described by a second COMMAND(), so that it is exposed by --introspect-cli
too.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 20cc6d3188 measure: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 24e24adfe1 machine-id-setup: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. An explicit "Commands" option group is added
so that the section heading stays the same.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek facaf8ba45 machinectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is now wrapped automatically.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 1c7253ca8f loginctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 8aee2501f8 journalctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The description refers to the "journalctl"
option namespace; the varlink-mode namespace is not described.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek f17f7cc35e imdsd: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 431e3f7def cryptenroll: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-18 16:54:09 +02:00
Zbigniew Jędrzejewski-Szmek 6868cee66f bootctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The "help" verb was defined as visible but the
old help() only printed the named verb groups, so it was never shown; it is
now hidden explicitly to keep the output unchanged.
2026-08-18 16:54:09 +02:00
Antonio Alvarez Feijoo e1515be25b clonesetup-generator: set IgnoreOnIsolate=yes on generated units
If /sysroot is mounted in the initrd on a cloned device, initrd-cleanup.service
will stop this unit (via `systemctl isolate initrd-switch-root.target`).

cryptsetup-generator, veritysetup-generator and integritysetup-generator all set
"IgnoreOnIsolate=yes" on their generated units for this reason.
2026-08-18 20:18:03 +09:00
Zbigniew Jędrzejewski-Szmek 4db6101058 coccinelle: increase coverage by the coccinelle checker (#43412) 2026-08-18 13:16:06 +02:00
Daan De Meyer 1807f827ed ci: don't run the review agent outside the workspace
Running the review step from /tmp/claude-review-sandbox put the directory the
review result has to be written to outside the agent's working directory. The
Write tool refuses to touch anything outside that directory, no matter what the
permission rules say, so every attempt to write review-result.json was denied.
Runs only passed because the agent fell back to writing the file from a
sandboxed shell command instead, and the last one hit the 50 minute step
timeout before it got that far, leaving nothing for the post job to upload.

The separate working directory bought little on top of the write allow rule,
which already confines the agent to claude-review-work/, so drop it and run in
the workspace again.
2026-08-18 10:41:39 +01:00
Zbigniew Jędrzejewski-Szmek d4fe62b8b3 Another batch of conversions to COMMAND and additions of --introspect-cli (#43418) 2026-08-18 11:38:45 +02:00
Zbigniew Jędrzejewski-Szmek a8e07fef9a bless-boot: make 'help' work also in containers
TEST-74-AUX-UTILS.introspect-cli.sh would fail because
'systemd-bless-boot help' would refuse to run in a container.
It's nicer to make 'help' work always.
2026-08-18 00:33:55 +02:00
Yu Watanabe b7d2a5ce43 coccinelle: ignore more attributes and macros
This also adds bus_assert_return() as an variant of assertion.

With this change, more code blocks are checked by coccinelle,
thus the test become slightly slower. So the timeout is extended.

Also, as checking exec_invoke() takes so long, let's skip it.
Note, previously the function was skipped due to parse error caused by
unknown cleanup attributes. So, the coverage is not decreased by the
skip.
2026-08-18 06:30:14 +09:00
Yu Watanabe 90481c0b1b tree-wide: add missing assertions
Found by coccinelle.
2026-08-18 06:30:10 +09:00
Yu Watanabe 05f790da8f dhcp: drop unnecessary !!
Found by coccinelle.
2026-08-18 03:33:37 +09:00
Lennart Poettering 31eaee07c3 ask-password-api: move oom check to the right place
Follow-up for: 92e2f70a3c
2026-08-18 02:12:00 +09:00
Zbigniew Jędrzejewski-Szmek ecb4685783 Another batch of conversions to COMMAND and additions of --introspect-cli (#43406) 2026-08-17 16:40:49 +02:00
Zbigniew Jędrzejewski-Szmek a508a1da5b inhibit: pass arg_json_format_flags to introspect_cli()
All other commands with a --json= option do so, so that --json= governs
the formatting of the introspection output.

Fixes 548c9cd71c.
2026-08-17 16:11:09 +02:00
Zbigniew Jędrzejewski-Szmek f2194e053f test: also exercise the "help" verb of introspectable commands
Verb-based commands register the help verb with
VERB_COMMON_HELP_AUTO("name"), where the name is spelled separately from
the one used for --help, so let's check that it works too.
2026-08-17 16:11:09 +02:00
Zbigniew Jędrzejewski-Szmek 10468a0164 meson: mark userdbctl as public
It is a documented user-facing tool installed into bindir like the other
*ctl tools, so give it the check-help and check-version tests too.
2026-08-17 16:11:09 +02:00
Zbigniew Jędrzejewski-Szmek d32d25847d userdbctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 16:11:09 +02:00
Zbigniew Jędrzejewski-Szmek 71f974a1eb ssh-issue: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is reworded to be a more
regular sentence.
2026-08-17 16:10:56 +02:00
Zbigniew Jędrzejewski-Szmek 4a32b1cbf1 sleep: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 6e19fb74bf sbsign: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract gains its missing trailing
period and says "PE binaries", like the man page.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek ef3bb712a7 report: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 2b875c24c9 random-seed: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek d1137e3cb1 portablectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The "(default)" suffix is dropped from the
help text of the "list" verb, since the default verb is now shown in
brackets in the Commands: table anyway.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 24fb06f158 oomctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 1ad1a47472 networkctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek de3bd5c46d localectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 618aa83e18 keyutil: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 2908468b39 importctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract gains its missing trailing
period.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 63ac493274 hostnamectl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 655cfb24af factory-reset: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract is reworded to "Query, request,
or cancel a factory reset operation."
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 7485176ea1 cryptsetup: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek e6858b9b31 creds: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The abstract loses its odd capitalization
("Display and process credentials."). --help now goes through the pager,
like other commands with --no-pager.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 6f63f2074e coredumpctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. --help now goes through the pager, like other
commands with --no-pager.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek d927ccf38a busctl: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. Verb and option column widths are kept
separate via COMMAND_HELP_SEPARATE, since the verb table is very wide,
as before.
2026-08-17 15:49:01 +02:00
Zbigniew Jędrzejewski-Szmek 8f53e3ac89 bless-boot: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added.
2026-08-17 13:32:25 +02:00
Zbigniew Jędrzejewski-Szmek fb4a092b9a test: check that systemd-clonesetup's verbs are described by --introspect-cli
Same as for systemd-hwdb and systemd-id128.
2026-08-17 13:21:31 +02:00
Zbigniew Jędrzejewski-Szmek 5eb3bf5182 storagetm: make the synopsis more accurate
parse_argv() requires at least one DEVICE unless --all is given, and
refuses DEVICE arguments when --all is given, so "[DEVICE…]" described
neither mode correctly. Spell out the three modes as separate synopsis
lines, like pcrextend and inhibit do, and update the man page to match.
2026-08-17 13:21:31 +02:00
Zbigniew Jędrzejewski-Szmek 9cf35bfa4d validatefs: convert to VERB_COMMAND and add --introspect-cli
The custom help() is replaced by a COMMAND() description, and
--introspect-cli is added. The positional argument is spelled MOUNTPOINT
in the synopsis, like the other metavars, instead of /path/to/mountpoint,
and the man page synopsis, which said "[DEVICE]", is fixed to match: the
argument is required and it is a mount point.
2026-08-17 13:21:31 +02:00