SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
70,397 Commits 2 Branches 1 Tag
a1bdae3645ae7336b6d440f150b987d246ce5d8d
Commit Graph
5836 Commits
Author SHA1 Message Date
Adrian Vovk a1bdae3645 fd-util: Close function for FD_TO_PTR 
Just a function to be used as a destructor (i.e. in a _cleanup_
attribute, hash table operations, etc.) that closes an fd wrapped in
FD_TO_PTR

It just retrieves the fd via PTR_TO_FD and closes it
 2024-01-19 12:27:05 -05:00
Lennart Poettering e7f2eef411 Merge pull request #30973 from mrc0mmand/gcc14 
Reorder arguments for calloc()-like functions, part #2
 2024-01-18 09:16:40 +01:00
Luca Boccassi 0a9735eac2 Merge pull request #30661 from rpigott/resolved-https-record 
resolved: support RFC 9460 SVCB and HTTPS records
 2024-01-17 16:20:35 +00:00
Luca Boccassi ed62937f78 user-util: remove dead code 
The branch explicitly checks that all of these ret_ variables are NULL,
so they will never be used.

Follow-up for 83e9b584db

CID#1533239
CID#1533240
CID#1533241
 2024-01-17 16:11:15 +00:00
Frantisek Sumsal dc571cccd7 macro: terminate the temporary VA_ARGS_FOREACH() array with a sentinel 
So gcc-14 doesn't complain we're out of bounds on the last iteration:

[2092/2414] Compiling C object test-macro.p/src_test_test-macro.c.o
In file included from ../src/basic/list.h:209,
                 from ../src/basic/log.h:10,
                 from ../src/test/test-macro.c:5:
../src/test/test-macro.c: In function ‘test_FOREACH_VA_ARGS’:
../src/basic/macro.h:395:90: warning: array subscript 1 is outside array bounds of ‘uint8_t[1]’ {aka ‘unsigned char[1]’} [-Warray-bounds=]
  395 |              ((long)(_current_ - _entries_) < (long)ELEMENTSOF(_entries_)) && ({ entry = *_current_; true; }); \
../src/basic/macro.h:392:9: note: in expansion of macro ‘_VA_ARGS_FOREACH’
  392 |         _VA_ARGS_FOREACH(entry, UNIQ_T(_entries_, UNIQ), UNIQ_T(_current_, UNIQ), ##__VA_ARGS__)
      |         ^~~~~~~~~~~~~~~~
../src/test/test-macro.c:322:9: note: in expansion of macro ‘VA_ARGS_FOREACH’
  322 |         VA_ARGS_FOREACH(u8, 0) {
      |         ^~~~~~~~~~~~~~~
../src/fundamental/macro-fundamental.h:163:37: note: at offset 1 into object ‘__unique_prefix__entries_181’ of size 1
  163 | #define UNIQ_T(x, uniq) CONCATENATE(__unique_prefix_, CONCATENATE(x, uniq))
      |                                     ^~~~~~~~~~~~~~~~
../src/basic/macro.h:394:28: note: in definition of macro ‘_VA_ARGS_FOREACH’
  394 |         for (typeof(entry) _entries_[] = { __VA_ARGS__ }, *_current_ = _entries_; \
      |                            ^~~~~~~~~
../src/fundamental/macro-fundamental.h:109:27: note: in expansion of macro ‘XCONCATENATE’
  109 | #define CONCATENATE(x, y) XCONCATENATE(x, y)
      |                           ^~~~~~~~~~~~
../src/fundamental/macro-fundamental.h:163:25: note: in expansion of macro ‘CONCATENATE’
  163 | #define UNIQ_T(x, uniq) CONCATENATE(__unique_prefix_, CONCATENATE(x, uniq))
      |                         ^~~~~~~~~~~
../src/basic/macro.h:392:33: note: in expansion of macro ‘UNIQ_T’
  392 |         _VA_ARGS_FOREACH(entry, UNIQ_T(_entries_, UNIQ), UNIQ_T(_current_, UNIQ), ##__VA_ARGS__)
      |                                 ^~~~~~
../src/test/test-macro.c:322:9: note: in expansion of macro ‘VA_ARGS_FOREACH’
  322 |         VA_ARGS_FOREACH(u8, 0) {
      |         ^~~~~~~~~~~~~~~
 2024-01-17 13:20:37 +01:00
Lennart Poettering 010cd1dc58 tree-wide: propagate the error we got from strv_extend_xyz() to the caller 
It's a bit sloppy to return -ENOMEM rather than the actual error we
already returned in the first place (even though it's always going to be
ENOMEM)
 2024-01-17 11:32:11 +01:00
Lennart Poettering 69f3c61990 tree-wide: port over various pieces of code to strv_extend_many() 2024-01-17 11:32:11 +01:00
Lennart Poettering 80f1e209a5 strv: add strv_extend_many() helper 
This is supposed to be a nicer, faster replacement for the often seen
pattern strv_extend_strv(l, STRV_MAKE(…), false)
 2024-01-17 11:32:11 +01:00
Lennart Poettering b9d37112f2 strv: remove strv_extend_front() 
It's entirely identical to strv_push_prepend() hence drop the duplicate
definition.
 2024-01-17 11:32:11 +01:00
Lennart Poettering a43431067e strv: modernize strv_insert() 
Let's use memmove() to move the string contents, rather than manual
loops.

Fix the overflow extension.

Prefer reallocarray() over malloc()
 2024-01-17 11:32:11 +01:00
Frantisek Sumsal fdd84270df Reorder arguments for calloc()-like functions, part #2 
To appease gcc-14's -Wcalloc-transposed-args check.

Follow-up for 2a9ab0974b.
 2024-01-17 11:09:09 +01:00
Ronan Pigott b699f5f2cd escape: introduce decescape 
This 3-digit decimal escape style is useful when presenting DNS RR
information in zone-file presentation format.
 2024-01-16 10:49:26 -07:00
Lennart Poettering e9c974fd42 user-util: honour PREFER_NSS flag in get_group_creds() the same way as we already do in get_user_creds() 
let's onour the PREFER_NSS flag also in get_group_creds() the same
way we honour it in get_user_creds().

Simply to remove surprises.
 2024-01-16 14:56:25 +01:00
Lennart Poettering 83e9b584db user-util: modernize get_user_creds() + get_group_creds() 
Let's rename return parameters to ret_xyz, and let's guarantee the usual
rule to initialize all return parameters on success, and not touch any
on failure.
 2024-01-16 14:55:45 +01:00
Ludwig Nussel 5058bd7e1f strv: introduce strv_copy_unless_empty() 2024-01-15 17:16:37 +01:00
Cristian Rodríguez 2a9ab0974b Fix gcc14 -Wcalloc-transposed-args warnings 
all functions annotated with two parameter _alloc_ are calloc-like.
gcc14 enforces this and warns if arguments are backwards.
 2024-01-14 12:57:38 +00:00
Lennart Poettering 06d4fe57c9 vmspawn: use our generic vsock CID parser, instead of a howngrown one 
Let's also use 'unsigned' as type for the CID everywhere, and
VMADDR_CID_ANY as marker for "invalid CID", as that's what the vsock
APIs natively do.
 2024-01-12 16:03:19 +01:00
Lennart Poettering 045f7b8fe4 iovec-util: add helper for a single NUL byte iovec 2024-01-11 16:05:20 +01:00
Rose aa9ff6c28d tree-wide: replace string functions with fundamental functions 2024-01-11 13:36:25 +09:00
Lennart Poettering a795ec8100 Merge pull request #30839 from yuwata/detect-virt-google 
detect-virt: add Google Compute Engine support
 2024-01-10 09:55:44 +01:00
Yu Watanabe 9b0688f491 virt: add Google Compute Engine support 
See https://cloud.google.com/run/docs/container-contract#sandbox
 2024-01-10 03:08:31 +09:00
Zbigniew Jędrzejewski-Szmek 8e1ac16bc6 src/basic: rename uid-alloc-range.[ch] to uid-classification.[ch] 
We had both uid-range.h and uid-alloc-range.h. The latter now contains helpers
like {uid,gid}_is_{system,dynamic,container}(), uid_for_system_journal(), so
the existing name is outdated. I think the uid-range.[ch] should stay separate
because it has a bunch of helpers for parsing and printing of uid ranges. So
let's rename as in $subject to better reflect the contents of the file and make
the two sets of files harder to confuse.
 2024-01-09 11:15:00 +01:00
Zbigniew Jędrzejewski-Szmek eb7d7d14fb src/basic: "UidRange" → "UIDRange" 
We don't "uncapitalize" parts of an already-capitalized name when concatenating
words. In particular, we had UidRange in basic/uid-range.h and UGIDAllocationRange
in basic/uid-alloc-range.h, which is annoying.
 2024-01-09 11:15:00 +01:00
Yu Watanabe 35716eed55 Merge pull request #30837 from poettering/varlink-over-ssh 
varlink: add "ssh:" transport for talking to remote servers
 2024-01-09 10:14:03 +09:00
Lennart Poettering fc1f05ebab socket-util: modernize socknameinfo_pretty() a bit 2024-01-09 10:00:21 +09:00
Lennart Poettering 3b1e80f7cb process-util: turn off O_NONBLOCK on stdio fds when rearranging fds 
We often create our fds O_NONBLOCK, but when we want to invoke some
program with them as stdin/stdout/stderr we really should turn it off
again.
 2024-01-08 23:23:42 +01:00
Lennart Poettering b20e9dc515 env-util: add new setenvf() helper 
And convert some pieces of code over.
 2024-01-08 23:22:58 +01:00
Mike Yuan bdd2036e81 hexdecoct: make unbase64mem and unhexmem always use SIZE_MAX 2024-01-09 03:59:15 +09:00
Yu Watanabe e701439998 virt: fix detection of avx2 and friends 
To get the CPUID with EAX=7, we need explicitly set 0 to ECX.

From Intel® Architecture Instruction Set Extensions Programming
Reference and Related Specifications,
===
Leaf 07H output depends on the initial value in ECX.
If ECX contains an invalid sub leaf index, EAX/EBX/ECX/EDX return 0
===

Fixes #30822.
 2024-01-08 16:04:17 +01:00
Lennart Poettering d3109d8de0 socket-util: add helper for querying the local AF_VSOCK CID 2024-01-08 10:26:34 +01:00
Yu Watanabe b82b4d258e Merge pull request #30794 from poettering/parse-vsock-better 
socket-util: add more careful parsers for AF_VSOCK cid/port
 2024-01-06 11:16:19 +09:00
networkException dcfac3a3f9 parse-helpers: allow port 0 for socket bind items 
This patch adds a new parameter to parse_ip_port_range, giving callers
the option to allow ranges to have their min be 0 instead of 1.

This is then used by parse_ip_ports_token, intern used by
parse_socket_bind_item to allow port 0 when restricting bind system
calls with SocketBindDeny / SocketBindAllow.

With this, users running server software written using the golang
standard library will be able to effectively sandbox their software,
albeit with a small loss in security protections by allowing the
process to bind on a random port in the
/proc/sys/net/ipv4/ip_local_port_range.
 2024-01-06 08:27:14 +09:00
Lennart Poettering 8e471c6a9f socket-util: add more careful parsers for AF_VSOCK cid/port 
Let's handle the magic CIDs, and filter out invalid ports.
 2024-01-05 22:29:55 +01:00
Lennart Poettering 41dd51f8f5 missing: add a bunch of vsock related defines 2024-01-05 22:29:55 +01:00
Lennart Poettering 2148c669d2 fileio: add new flag WRITE_STRING_FILE_MODE_0444 
With this write_string_file() will create the file with 0444 access mode
(i.e. read-only).
 2024-01-05 17:30:41 +01:00
Lennart Poettering dddc12f9eb iovec-util: add CONST_IOVEC_MAKE_STRING() 2024-01-05 11:10:22 +01:00
Lennart Poettering 4cc467b67c iovec-util: add new iovec_memdup() helper 2024-01-05 11:10:22 +01:00
Lennart Poettering bf38e4c0c1 iovec-util: add new iovec_memcmp() helper 2024-01-05 11:10:22 +01:00
Lennart Poettering 39f586873d iovec-util: add iovec_is_valid() helper 2024-01-05 11:10:22 +01:00
Lennart Poettering 33d1febbd7 iovec-util: rework IOVEC_MAKE_STRING() to work with compound initialized input 
This avoids the ({}) that IOVEC_MAKE_STRING() so far used and might
cause a memory corruption if the parameter passed in is itself allocated
via a compount initialized array or so.

Also, this makes sure both IOVEC_MAKE_STRING() and IOVEC_MAKE() accept
'const' parameters without this causing a compiler warning.
 2024-01-05 11:10:22 +01:00
Yu Watanabe 9e44842a9a string-util: fix typo 
Follow-up for 63566c6b6f.
 2024-01-05 19:08:12 +09:00
Adrian Vovk d3c2288c9f stat-util: Add statx version of timespec_load 
statx_timestamp is, for all intents and purposes, the same as a struct
timespec. So, we can trivially convert it and call timespec_load on it.

This commit adds helper functions that do just that.
 2024-01-04 12:49:14 -05:00
Yu Watanabe 7903567cb7 Merge pull request #30610 from YHNdnzj/logind-serialize-pidref 
logind: serialize session leader pidfd to fdstore
 2024-01-04 23:25:18 +09:00
Lennart Poettering 96fc8cab2a Merge pull request #30578 from bluca/polkit-varlink 
varlink: add glue to allow authenticating varlink connections via polkit
 2024-01-04 15:15:45 +01:00
Mike Yuan 2e6f012bf0 strv: rename strv_endswith to endswith_strv and dedup ENDSWITH_SET 2024-01-04 16:51:57 +08:00
Mike Yuan eba8b54130 string-util: move startswith_strv to strv 2024-01-04 16:49:05 +08:00
Mike Yuan 53190aa693 string-util: use strneq 2024-01-04 16:49:05 +08:00
Mike Yuan faf0dd4b29 process-util: ensure pidref_is_alive only return ESRCH if not set 2024-01-04 16:19:20 +08:00
Lennart Poettering 2a02a8db91 Merge pull request #26663 from poettering/vpick 
add new "vpick" concept for automatically picking newest resource from .v/ dir containing versioned files
 2024-01-03 22:17:32 +01:00
Rose b4a9d19e4e basic: fix overflow detection in sigbus_pop 
The current check checks for n_sigbus_queue
being greater than or equal to SIGBUS_QUEUE_MAX,
when it should be just greater than as
n_sigbus_queue being SIGBUS_QUEUE_MAX indicates
that the queue is full, but not overflowed.
 2024-01-04 05:26:01 +09:00