SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
56,310 Commits 2 Branches 1 Tag
a57d72ceb48f83b832f3745f381dc94de6ca1a52
Commit Graph
56310 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Daan De Meyer 9519b41e52 shared: Remove remaining usages of GPT_ROOT_NATIVE, GPT_USR_NATIVE from dissect-image.c 
Follow-up for 49ae9d91f9

Fixes #21843
 2021-12-21 13:47:07 +00:00
Zbigniew Jędrzejewski-Szmek 5b1cf7a9be shared/rm-rf: loop over nested directories instead of instead of recursing 
To remove directory structures, we need to remove the innermost items first,
and then recursively remove higher-level directories. We would recursively
descend into directories and invoke rm_rf_children and rm_rm_children_inner.
This is problematic when too many directories are nested.

Instead, let's create a "TODO" queue. In the the queue, for each level we
hold the DIR* object we were working on, and the name of the directory. This
allows us to leave a partially-processed directory, and restart the removal
loop one level down. When done with the inner directory, we use the name to
unlinkat() it from the parent, and proceed with the removal of other items.

Because the nesting is increased by one level, it is best to view this patch
with -b/--ignore-space-change.

This fixes CVE-2021-3997, https://bugzilla.redhat.com/show_bug.cgi?id=2024639.
The issue was reported and patches reviewed by Qualys Team.
Mauro Matteo Cascella and Riccardo Schirone from Red Hat handled the disclosure.
 2021-12-21 14:39:50 +01:00
Zbigniew Jędrzejewski-Szmek 84ced33002 shared/rm_rf: refactor rm_rf() to shorten code a bit 2021-12-21 14:36:56 +01:00
Zbigniew Jędrzejewski-Szmek 3bac86abfa shared/rm_rf: refactor rm_rf_children_inner() to shorten code a bit 2021-12-21 14:36:56 +01:00
Scott Worley 77ec2816c6 timedatectl: Uniform commas in NTPMessage output 2021-12-21 09:46:19 +09:00
Frantisek Sumsal 2cb726adf5 test: tweak the path trigger limit a bit when collecting coverage 
Basically the same thing as in e70103e, but for TEST-63. Uses
directives introduced by 47dba9f.

Follow-up to aaae822.
 2021-12-20 22:05:14 +00:00
Zbigniew Jędrzejewski-Szmek 28be02e005 NEWS: add missing noun 2021-12-20 19:39:35 +01:00
Yu Watanabe a2482eb290 Merge pull request #21839 from yuwata/repart-issue-reproducer-21817 
test: add test case for #21817
 2021-12-21 02:30:53 +09:00
Daan De Meyer 94c5a83c6e journal: Handle partially read HashItem's when punching holes 2021-12-21 02:29:57 +09:00
Zbigniew Jędrzejewski-Szmek 8ef114c692 nss-resolve: expose various source-disablement settings as variables 
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2006761:
> systemd-resolved always (reverse)-resolves the host's IP addresses and FQDN.
> This can be harmful when an application (for instance, a DNS zone manager) is
> installed on the same server instance.  That application would expect
> NXDOMAIN to be returned if the current server's IP does not belong in an
> already managed reverse zone.

This allows clients of nss-resolve to use the same config options that are
available through the dbus api and as command-line options to resolvectl.

The man page text is is mostly copied directly from
c6f20515ab.
 2021-12-21 02:28:52 +09:00
Yu Watanabe 71bb604807 test: add a test case for issue #21817 2021-12-21 00:28:39 +09:00
Yu Watanabe 92ecc87512 test: install losetup by default 
Preparation for the next commit.
 2021-12-20 23:34:27 +09:00
Luca Boccassi 616779c345 NEWS: add note about path unit's TriggerLimitBurst= and TriggerLimitIntervalSec= 2021-12-20 13:52:49 +00:00
Tom Yan d8daed09f3 repart: use real disk start/end for bar production 
Partitions are not always within our aligned scope. Bar printing
involves foreign partitions as well.

Fixes #21817.
 2021-12-20 14:50:08 +01:00
Zbigniew Jędrzejewski-Szmek 21747dcd3b hwdb: update for -rc3 
Just a small bunch of additions and a naming updates.
 2021-12-20 14:36:35 +01:00
Yu Watanabe 30df858f43 journal-remote: use MHD_HTTP_CONTENT_TOO_LARGE as MHD_HTTP_PAYLOAD_TOO_LARGE is deprecated since 0.9.74 2021-12-20 14:30:24 +01:00
Luca Boccassi 077c5cf669 Merge pull request #21831 from keszybz/man-dnssec-fixlets 
Fixlets for DNSSEC-related documentation
 2021-12-20 12:04:41 +00:00
Zbigniew Jędrzejewski-Szmek c20ecc9457 NEWS: add the boot loader stuff 2021-12-20 12:23:40 +01:00
dependabot[bot] 219c1dc780 build(deps): bump actions/upload-artifact from 2.3.0 to 2.3.1 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/da838ae9595ac94171fa2d4de5a2f117b3e7ac32...82c141cc518b40d92cc801eee768e7aafc9c2fa2)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-12-20 13:14:23 +03:00
Zbigniew Jędrzejewski-Szmek e803cf2139 man: correctly document default for DNSSEC= and DNSoverTLS= 
https://bugzilla.redhat.com/show_bug.cgi?id=1926323
 2021-12-20 10:56:14 +01:00
Zbigniew Jędrzejewski-Szmek c6f20515ab man: describe flags for record resolving 2021-12-20 10:56:14 +01:00
Zbigniew Jędrzejewski-Szmek 1c4539afc0 man: describe $SYSTEMD_NSS_RESOLVE_VALIDATE 
This variable has a pretty important effect, but we didn't mention it
anywhere in the docs. It was added in aee9d18c8d.
 2021-12-20 10:51:51 +01:00
Daan De Meyer 3e6357de9d Merge pull request #21807 from keszybz/bootcls-no-autodetect 
Use KERNEL_INSTALL_MACHINE_ID and KERNEL_INSTALL_LAYOUT with bootctl install
 2021-12-20 10:43:18 +01:00
Mike Gilbert 9a723ed6e8 basic: add a size check to format timex members properly 
As of glibc-2.34, the size of members in struct timex varies depending on
the _TIME_BITS macro.

Fixes: https://github.com/systemd/systemd/issues/21826
 2021-12-20 12:36:59 +09:00
Yu Watanabe b9f27a0567 sd-radv: do not use goto for non-error-handling cases 
Follow-up for 059d7b6eae.

The comment https://github.com/systemd/systemd/pull/21814#discussion_r771842132
suggests to introduce new helper, but it is used only one place.
Let's not add such, but simply replace the goto with a flag.
 2021-12-19 12:23:14 +00:00
Daan De Meyer 73b3314bfd Merge pull request #21818 from bluca/path_trigger_limit 
path unit: add TriggerLimitBurst= and TriggerLimitIntervalSec=
 2021-12-19 12:42:11 +01:00
Nishal Kulkarni a6293b0541 logind: Use new macros 
Migrate logind to use the new macros to declare a D-Bus method or signal.
Replaced SD_BUS_METHOD_WITH_NAMES with SD_BUS_METHOD_WITH_ARGS.
Replaced SD_BUS_SIGNAL_WITH_NAMES with SD_BUS_SIGNAL_WITH_ARGS.
 2021-12-19 09:14:07 +09:00
Yu Watanabe ecb0be874d Merge pull request #21814 from yuwata/network-dhcp-pd-fixes 
network: several fixes for DHCP prefix delegation
 2021-12-19 08:52:08 +09:00
Luca Boccassi 47dba9fb09 path unit: add TriggerLimitBurst= and TriggerLimitIntervalSec= 
Given there's now a default for these settings, also allow users to configure
them, matching socket units
 2021-12-18 23:17:53 +00:00
Luca Boccassi ef1aa10692 man: fix typo in systemd.socket.5 2021-12-18 17:23:53 +00:00
Luca Boccassi 5cfe61f2de Merge pull request #21808 from DaanDeMeyer/path-trigger-limit 
core: Add trigger limit for path units
 2021-12-18 16:56:05 +00:00
Yu Watanabe ccadf9ac0d udev: do not kill "udevadm control" process in the same cgroup 
Fixes #16867.
 2021-12-18 20:05:26 +09:00
Yu Watanabe f9da11ef1e udev-ctrl: make udev_ctrl_send() accept integer and string through a single argument 2021-12-18 19:41:14 +09:00
Daan De Meyer aaae822b37 core: Add trigger limit for path units 
When conditions fail on a service unit, a path unit can cause
PID 1 to busy loop as it keeps trying to activate the service unit.
To avoid this from happening, add a trigger limit to the path unit,
identical to the trigger limit we have for socket units.

Initially, let's start with a high limit and not make it configurable.
If needed, we can add properties to configure the rate limit similar
to the ones we have for socket units.
 2021-12-18 11:26:25 +01:00
Nishal Kulkarni 9a8141662e homed: Use new SD_BUS_METHOD_WITH_ARGS macro 
Migrate homed to use the new macros to declare a D-Bus method.
Replaced `SD_BUS_METHOD_WITH_NAMES` with `SD_BUS_METHOD_WITH_ARGS`
 2021-12-18 11:57:57 +09:00
Yu Watanabe 6a936c9c9a test-network: add tests for renewing/rebinding lease 2021-12-18 10:09:07 +09:00
Yu Watanabe 2616b5285f test-network: introduce dump_dnsmasq_log_file() 2021-12-18 10:09:07 +09:00
Yu Watanabe 4862fb693d test-network: use dnsmasq for testing DHCP4-6RD 2021-12-18 10:09:07 +09:00
Yu Watanabe f56af3b4c8 test-network: use --bind-interfaces option for dnsmasq 
Also make the interface name and router address configurable.
 2021-12-18 10:09:07 +09:00
Yu Watanabe 897f720602 sd-dhcp-client: add log message when a message is received 2021-12-18 10:09:07 +09:00
Yu Watanabe fe87807eaa network: dhcp-pd: do not stack 6rd sit tunnel 2021-12-18 10:09:07 +09:00
Yu Watanabe 42e7ce69e4 network: route: update expiration timer in link_request_route() 2021-12-18 10:09:07 +09:00
Yu Watanabe d0f17cfda6 network: route: do not drop unreachable route on reconfiguring downstream interface 
Previously, when a downstream is reconfigured, the unreachable route
was removed as there is no corresponding static config in .network
files.
 2021-12-18 10:09:07 +09:00
Yu Watanabe 277521a1ac network: dhcp-pd: fix condition in dhcp_pd_prefix_lost() 2021-12-18 10:09:07 +09:00
Yu Watanabe 059d7b6eae sd-radv: send RA when prefix is updated 2021-12-18 10:09:07 +09:00
Frantisek Sumsal c0a2e0cc24 network: a couple of tweaks suggested by Coccinelle 2021-12-18 08:36:07 +09:00
Yu Watanabe 14dd873b88 network: dhcp4: pass IPServiceType=none to dhcp client 
Follow-up for b55093ce88.
 2021-12-18 08:35:42 +09:00
Frantisek Sumsal b5c946d3b8 man: fix machine-id(5) man page reference 
Spotted whilst debugging:
```
[763/2094] Generating man/machine-info.html with a custom command
Element cite in namespace '' encountered in para, but no template matches.
[765/2094] Generating man/machine-info.5 with a custom command
Element cite in namespace '' encountered in para, but no template matches.
```

Follow-up to 357376d0bb.
 2021-12-18 08:35:24 +09:00
Yu Watanabe a00fd2a553 Merge pull request #21800 from keszybz/net-id-debugging 
Add more debugging info to udev builtin net_id
 2021-12-18 08:35:08 +09:00
Daan De Meyer 40f41f34d4 Revert "core: Propagate condition failed state to triggering units." 
This reverts commit 12ab94a1e4.
 2021-12-17 19:39:29 +01:00