SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
88,460 Commits 2 Branches 1 Tag
ae973bb61767fce6b428f52b20cfcddf2c70c944
Commit Graph
19 Commits
Author SHA1 Message Date
Daan De Meyer fbd276cb86 tree-wide: Use pidref_wait_for_terminate_and_check() 
Let's use the pidref variants for waiting and
checking a process everywhere and get rid of the
non pidref variants.
 2025-12-20 15:50:47 +01:00
Lennart Poettering ed3fcaae11 crash-handler: also disable dlopen(), just in case 2025-11-24 11:56:47 +01:00
Yu Watanabe 4f18ff2e29 tree-wide: include unistd.h where necessary 
We use symbols provided by unistd.h without including it. E.g.
open(), close(), read(), write(), access(), symlink(), unlink(), rmdir(),
fsync(), syncfs(), lseek(), ftruncate(), fchown(), dup2(), pipe2(),
getuid(), getgid(), gettid(), getppid(), pipe2(), execv(), _exit(),
environ, STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO, F_OK, and their
friends and variants, so on.

Currently, unistd.h is indirectly included mainly in the following two paths:
- through missing_syscall.h, which is planned to covert to .c file.
- through signal.h -> bits/sigstksz.h, which is new since glibc-2.34.
  Note, signal.h is included by sd-eevent.h. So, many source files
  indirectly include unistd.h if newer glibc is used.

Currently, our baseline on glibc is 2.31. We need to support glibc older
than 2.34, but unfortunately, we do not have any CI environments with
such old glibc. CIFuzz uses glibc-2.31, but it builds only fuzzers, and
many files are even not compiled.
 2025-06-30 09:19:15 +02:00
Lennart Poettering 1105f8d20f tree-wide: only use .si_pid field in siginfo_t, if .si_code indicates that's safe 
Fixes: #37498
 2025-05-31 14:48:37 +02:00
Daan De Meyer 836e4e7ea8 core: Clean up includes 
Split out of #37344.
 2025-05-22 09:37:20 +02:00
Yu Watanabe 3cf6a3a3d4 tree-wide: check more log message format in log_struct() and friends 
This introduce LOG_ITEM() macro that checks arbitrary formats in
log_struct().
Then, drop _printf_ attribute from log_struct_internal(), as it does not
help so much, and compiler checked only the first format string.

Hopefully, this silences false-positive warnings by Coverity.
 2025-03-19 01:56:48 +09:00
Mike Yuan fafb05451f core: move CrashAction enum def to crash-handler.[ch] 2025-03-08 20:40:23 +01:00
Mike Yuan 5734893f82 tree-wide: make sigactions static const 2025-01-04 16:40:53 +01:00
Mike Yuan bed4386e29 signal-util: generalize sigaction_nop_nocldstop 2025-01-04 16:40:53 +01:00
Daan De Meyer 1b275c2acd crash-handler: Add back notice log message 
Fixes https://github.com/systemd/systemd/pull/33959#discussion_r1730987738
 2024-08-26 16:36:39 +02:00
Daan De Meyer 570a11eb9d crash-handler: Drop 10s sleep before we spawn the crash shell 
It pointlessly delays getting to the crash shell so let's drop the
10s sleep.
 2024-08-07 21:26:53 +02:00
Daan De Meyer bc3477fdc5 crash-handler: Call vhangup on /dev/console before spawning crash shell 
When pid 1 crashes, the getty unit for the console will happily keep
running which means we end up with two shells competing for the same
tty. Let's call vhangup on /dev/console to kill every other process
attached to the console before we spawn the crash shell. The getty
units have Restart=always but lucky for us, pid 1 just crashed in fire
and flames so it isn't actually able to restart the getty unit.
 2024-08-07 21:24:57 +02:00
Lennart Poettering 0bd7217634 signal-util: use common definitions for ignore + default "struct sigaction" 
We use this at various places, let's unify this in one global constant.

This changes flags in crash-handler.c in a tiny irrelevant way: we ask
syscalls to be continued on signal arrival, which we previously didn't.
But that shouldn't change anything, the only thing we'll do in the
relevant process is call raise(), and that's it, hence there definitely
are no syscalls to restart or not to restart.
 2024-07-12 08:26:15 +02:00
Daan De Meyer 7a66f21556 core: Add systemd.crash_action= kernel command line argument 
Required for integration tests to power off on PID 1 crashes. We
deprecate systemd.crash_reboot and related options by removing them
from the documentation but still parsing them.
 2024-04-29 14:34:22 +02:00
Mike Yuan acee9a9c09 core/crash-handler: correct indentation 2023-09-04 22:45:45 +08:00
OMOJOLA JOSHUA ad5db9404e Journal: Add message IDs for emergency-level log messages 2023-09-01 13:59:21 +01:00
Lennart Poettering 128a11ea99 signal-util: add common implementation for propagating a signal 
i.e. let's add a common logic to be called from a signal handler to
raise the passed signal again.

Follow-up for: #25399
 2022-11-17 22:38:14 +09:00
Daan De Meyer 2af3e23fc0 crash-handler: Make sure we propagate the original siginfo 
If we call raise(), we lose the information from the original signal.
If we use rt_sigqueueinfo(), the original siginfo gets reused which
is helpful when debugging crashes.
 2022-11-16 16:07:35 +01:00
Lennart Poettering 898c9a6f97 pid1: split out crash handler logic into its own .c/.h file 
This stuff is sufficiently different from the rest of main.c, let's move
it to its own .c/.h file, to make main.c a bit shorter.

No code changes, just some refactoring.
 2022-03-10 13:45:14 +01:00