Zbigniew Jędrzejewski-Szmek
2686114332
basic,shared: move quota-util.[ch] to src/shared/
...
No need for this to in basic/.
2021-06-24 09:47:15 +02:00
Zbigniew Jędrzejewski-Szmek
65ddc2c5ff
basic: drop one btrfs-related function and move another
...
This will become useful later, it is the first step to moving btrfs-util.[ch]
out of src/basic/.
2021-06-24 09:42:08 +02:00
Yu Watanabe
38e980a6a5
sd-dhcp-client: tentatively ignore FORCERENEW command
...
This makes DHCP client ignore FORCERENEW requests, as unauthenticated
FORCERENEW requests causes a security issue (TALOS-2020-1142, CVE-2020-13529).
Let's re-enable this after RFC3118 (Authentication for DHCP Messages)
and/or RFC6704 (Forcerenew Nonce Authentication) are implemented.
Fixes #16774 .
2021-06-24 11:25:26 +09:00
Yu Watanabe
551ad0b7de
sd-dhcp-client: logs when dhcp client unexpectedly gains a new lease
...
Previously, such situation is handled silently.
2021-06-24 11:25:26 +09:00
Yu Watanabe
d57b62be0d
sd-dhcp-client: shorten code a bit
2021-06-24 11:25:26 +09:00
Yu Watanabe
67d8cd8193
sd-dhcp-client: check error earlier and reduce indentation
2021-06-24 11:25:26 +09:00
Anders Wenhaug
4dbad977ff
docs: add coding style example
...
Add example of how to structure else-blocks following a multiline block.
2021-06-24 10:06:40 +09:00
Yu Watanabe
f565b8676f
dirent-util: use readdir_ensure_type() in readdir_no_dot() and FOREACH_DIRENT()
2021-06-24 04:29:40 +09:00
Yu Watanabe
98f7a4c8bb
dirent-util: introduce readdir_ensure_type()
2021-06-24 04:19:38 +09:00
Zbigniew Jędrzejewski-Szmek
6d216bdd07
test-path-util: check that dot components are irrelevant for path comparisons
2021-06-23 18:11:49 +02:00
Zbigniew Jędrzejewski-Szmek
a79726113a
TODO: elide initrd-parse-etc.service if possible
2021-06-23 18:11:49 +02:00
Zbigniew Jędrzejewski-Szmek
aa45911b79
man/50-xdg-data-dirs: add quotes as suggested by shellcheck
2021-06-23 18:11:49 +02:00
Zbigniew Jędrzejewski-Szmek
9c6535367d
basic,shared: move make_mount_point_inode_*() to shared/
...
Those pull in selinux for labelling, and we should avoid selinux in basic/.
2021-06-23 10:34:58 +02:00
Zbigniew Jędrzejewski-Szmek
f69c2926f8
meson: sort file list
...
At least emacs thinks this is the right way.
2021-06-23 10:29:37 +02:00
Yu Watanabe
5118e8e71d
udev: remove unsafe characters from ID_SERIAL for nvme
...
Fixes #19309 .
2021-06-23 17:11:27 +09:00
Yu Watanabe
91c27ac686
man: update description of "string_escape=" udev option
2021-06-23 17:11:23 +09:00
Yu Watanabe
ea0f4578a7
udev: replace unsafe characters on assigning ENV{key}="val" when OPTIONS="string_escape=replace" is set
...
Strictly speaking, this breaks backward compatibility, as previously
`ENV{key}="val"` ignored `string_escape=` option. But, introducing
a new option such as `string_escape=hoge` sounds overkill for me.
The default escape mode is `ESCAPE_UNSET`, so I hope this merely break
existing rules.
2021-06-23 16:40:52 +09:00
Yu Watanabe
51c2f543d1
udev: fix key name in debug log
2021-06-23 16:33:14 +09:00
Yu Watanabe
068b0f7728
udev: refuse invalid ifname earlier
2021-06-23 16:32:42 +09:00
Yu Watanabe
b4d885f0e8
udev: introduce new netif naming scheme flag to strictly replace ifname
2021-06-23 16:10:26 +09:00
Yu Watanabe
d37f3e3ec5
udev: only network interface can be renamed
2021-06-23 16:02:43 +09:00
Yu Watanabe
e1ecfef16f
udev-util: introduce udev_replace_ifname()
2021-06-23 16:02:05 +09:00
Yu Watanabe
5a3586db9a
socket-util: split out checking valid character for ifname into ifname_valid_char()
2021-06-23 15:59:44 +09:00
Yu Watanabe
b905f3bbba
Merge pull request #19990 from mrc0mmand/test-tweaks
...
A couple of stability-related test tweaks
2021-06-23 01:45:04 +09:00
Yu Watanabe
de806cd6b6
Merge pull request #19991 from bluca/bash_compl_unbound_vars
...
completion: fix 'unbound variables' errors
2021-06-23 01:44:30 +09:00
Luca Boccassi
36ec026830
completion: fix 'unbound variables' errors
...
Fixes https://github.com/systemd/systemd/issues/19987
2021-06-22 14:56:47 +01:00
Luca Boccassi
6a0667d2b6
completion/systemd-delta,-resolve: autocomplete with parameters
2021-06-22 14:56:47 +01:00
Luca Boccassi
df7ca94009
completion/hostnamectl: do not dereference non-existing OPTS[ARGUNKNOWN]
2021-06-22 14:56:47 +01:00
Lennart Poettering
abfbfee36c
Merge pull request #19986 from keszybz/test-mount-util-more
...
Add smoke test for mount_flags_to_string()
2021-06-22 15:03:57 +02:00
Hristo Venev
2e8a32afbc
networkd: Permit all-zero RoutingPolicyRule prefixes
...
For example this `From` address range is no longer ignored:
[RoutingPolicyRule]
From=0.0.0.0/8
2021-06-22 20:19:12 +09:00
Frantisek Sumsal
ffd0815171
Merge pull request #19969 from bluca/test_02_qemu
...
test-loop-block: run in qemu
2021-06-22 12:58:07 +02:00
Frantisek Sumsal
179ca4d2b1
test: correctly mask supporting services in tests
...
It turns out the "supporting services" were run in _all_ tests if
TEST-01-BASIC was run as the first test (which is usually the case),
since with the original condition in test_create_image() we would skip
the masking and then propagate the change to the default image used by
other tests. This has been causing multiple bogus test timeouts
(especially when the hwdb was being rebuilt in tests with short
timeouts, like TEST-52-HONORFIRSTSHUTDOWN).
Let's "fix" this by making the call to mask_supporting_services()
uncoditional and override the test_create_image() function in
TEST-01-BASIC to avoid the masking in this single case.
2021-06-22 12:34:31 +02:00
simmon
d8301aef51
po: Translated using Weblate (Korean)
...
Currently translated at 100.0% (189 of 189 strings)
Co-authored-by: simmon <simmon@nplob.com >
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ko/
Translation: systemd/main
2021-06-22 12:24:35 +02:00
Frantisek Sumsal
907300c3c3
test: ignore the "freezing" & "thawing" intermediate states
...
When checking the unit state after `systemctl freeze|thaw` we can be
"too fast" and get the intermediate state (freezing/thawing) which we're
not interested in. Let's wait a bit and try to get the state again in
such cases to avoid unnecessary flakiness.
```
[ 29.390203] testsuite-38.sh[218]: + state=thawing
[ 29.390203] testsuite-38.sh[218]: + '[' thawing = running ']'
[ 29.390203] testsuite-38.sh[218]: + echo 'error: unexpected freezer state, expected: running, actual: thawing'
[ 29.390203] testsuite-38.sh[218]: error: unexpected freezer state, expected: running, actual: thawing
[ 29.390203] testsuite-38.sh[218]: + exit 1
```
2021-06-22 12:12:34 +02:00
Zbigniew Jędrzejewski-Szmek
51bb6a103e
test-mount-util: add output test for mount_flags_to_string()
2021-06-22 14:42:03 +09:00
Zbigniew Jędrzejewski-Szmek
917578880f
test-mount-util: add usual print headers
2021-06-22 14:42:03 +09:00
Yu Watanabe
4bee2333cf
mount-util: add one more assertion
2021-06-22 14:42:03 +09:00
Luca Boccassi
b152adbfa9
test-loop-block: run in qemu
...
test-loop-block needs to run in qemu, so we are currently not
testing it in the CI. Run it by itself in a separate job from
TEST-02-UNITTESTS to avoid slowing that suite down.
Fixes https://github.com/systemd/systemd/issues/19966
Disable it in the bionic-* CI for now, as it's affected by
the same uevent ordering issue as TEST-50-DISSECT which makes
it flaky.
2021-06-21 20:55:19 +01:00
Luca Boccassi
fa1fdd3099
test: move custom result checks from TEST-02-UNITTESTS to test-functions
2021-06-21 20:45:56 +01:00
Luca Boccassi
85d3f13254
test: allow to call units/testsuite-02.sh from other scripts
2021-06-21 19:47:38 +01:00
Luca Boccassi
1d5574516f
test: do not fail TEST-02-UNITTESTS if they are all skipped
...
The return code is initialized to fail if /testok is not found, but
that also covers the case where all tests are skipped.
2021-06-21 19:47:38 +01:00
Luca Boccassi
7d3f9bf493
test: do not lose logs of late failures in TEST-02-UNITTESTS
...
Due to set -e, if the wait() fails (eg: because of an assert in the
waited task), report_result() never runs and logs are lost
2021-06-21 19:47:38 +01:00
Luca Boccassi
35cde9e935
test: install nls modules, required by vfat
...
kernel: FAT-fs (loop0p2): codepage cp437 not found
kernel: FAT-fs (loop0p2): IO charset ascii not found
2021-06-21 19:47:38 +01:00
Zbigniew Jędrzejewski-Szmek
b5ce2feebc
Merge pull request #19977 from yuwata/nspawn-fix-strextend
...
nspawn: replace strextend_with_separator() -> strextendf_with_separator()
2021-06-21 19:24:39 +02:00
Lennart Poettering
6e766d9874
cryptenroll: fix minor typo in --help ( #19985 )
...
We use "+" as separator for PCR indexes now, but we forgot to replace
one "," by "+"
2021-06-22 00:56:52 +09:00
Yu Watanabe
9b23679e53
mount-util: use EXTRACT_KEEP_QUOTE to handle mount options
...
Otherwise, the quotes which wrap SELinux options are dropped.
2021-06-21 21:34:50 +09:00
Yu Watanabe
25086b4c17
mount-util: reduce scope of variable
2021-06-21 21:34:10 +09:00
Yu Watanabe
f59551f18e
test: add test cases for EXTRACT_KEEP_QUOTE and EXTRACT_UNQUOTE
2021-06-21 21:34:07 +09:00
Yu Watanabe
1104d11429
extract-word: introduce EXTRACT_KEEP_QUOTE flag
2021-06-21 21:14:20 +09:00
Yu Watanabe
1c092b62db
mount-util: make mount_flags_to_string() show flag name instead of number
...
This also adds missing MS_NOSYMFOLLOW flag. Moreover, this makes the
function always add unhandled flags in number.
2021-06-21 21:14:20 +09:00