Mike Yuan
86dea48ddf
bus-wait-for-units: correctly report state if disconnected from bus
2024-01-01 18:42:24 +08:00
Mike Yuan
0ffcc7539b
bus-wait-for-units: rephrase error message
2024-01-01 18:42:24 +08:00
Mike Yuan
a490aa5a2d
bus-wait-for-units: use hashmap_remove_value where appropriate
2024-01-01 18:42:23 +08:00
Mike Yuan
edba11cbd1
bus-wait-for-jobs: remove unneeded strna and refactor code a bit
2024-01-01 18:42:23 +08:00
Mike Yuan
6aac0ff01c
bus-wait-for-jobs: a few modernizations
2024-01-01 18:16:54 +08:00
Mike Yuan
e945d395e2
bus-wait-for-jobs: rephrase error message
2024-01-01 15:58:52 +08:00
Mike Yuan
a8af9745e5
bus-wait-for-jobs: reorganize functions
2024-01-01 15:57:55 +08:00
Mike Yuan
b8f4a205f7
bus-wait-for-jobs: sort includes
2024-01-01 15:45:05 +08:00
Yu Watanabe
73780aa8a3
resolve: DnsTransaction.scope may be NULL when dns_transaction_close_connection() is called
...
Follow-up for ac1b7b9e19 .
Fixes CID#1533020.
2023-12-31 04:51:59 +09:00
Yu Watanabe
d05649ca7d
resolve: add several comments for DNS type table
...
Also update compile time checks.
Follow-up for 818bb6f482 .
2023-12-31 04:51:42 +09:00
Joakim Nohlgård and Yu Watanabe
ba340e2a75
udevadm: Propagate return code from verb result
...
udevadm lock did not propagate the return code from the child process
because all positive values were treated as success.
v2:
Now 'udevadm test-builtin' ignores all positive return values from the
builtin commands. Otherwise, as the hwdb builtin returns an positive value
when a matching entry found, 'udevadm test-builtin hwdb' will fail.
v3:
Initialize partition table before calling 'sfdisk --delete'.
Co-authored-by: Yu Watanabe <watanabe.yu+github@gmail.com >
2023-12-30 05:26:59 +09:00
Mike Yuan
6b9cac874c
fd-util: don't eat up errors in fd_cloexec_many
...
Follow-up for ed18c22c98
Before this commit, a successful fd_cloexec() call would
discard all previously gathered errors.
2023-12-29 14:26:40 +01:00
Yu Watanabe
5b201ffb1e
sd-journal: check sd-event state before setting up post change timer
...
The similar check already exists in schedule_post_change().
The function is currently called at two places.
- journal_file_open() in sd-journal:
In this case, if the timer is not set up, then journal_file_post_change()
will be called at the end of journal_file_append_entry(). So, the necessary
task will be done sequentially when an journal entry is stored to the opened
journal file. That is desired when the function is called at outside of the
event loop.
- server_open_journal() in journald:
This is not called after we exit the event loop.
So, we can safely do nothing in the function if the event loop is being
finished or already finished.
Fixes #30644 .
2023-12-29 06:39:06 +09:00
Ronan Pigott
818bb6f482
dns: update record type enum to match iana
...
Adds some new dns record types. Also, some types were inserted into the
middle of the enum — this corrects an error where the enum constants for
some of the record types previously held an incorrect value.
2023-12-29 04:08:41 +09:00
Mike Yuan
da6c52c57c
various: don't use close_nointr if retval is not checked anyway
2023-12-28 20:44:01 +08:00
Mike Yuan
1189815a6b
logind-session-device: use _cleanup_close_
2023-12-28 20:43:42 +08:00
Mike Yuan
3760416ee8
shared/async: use safe_close where appropriate
2023-12-28 18:26:52 +08:00
Mike Yuan
1cbd441b09
fdset: use FOREACH_ARRAY at one more place
2023-12-28 18:26:52 +08:00
Mike Yuan
1276e63370
fd-util: modernization
2023-12-28 18:26:52 +08:00
Chris Simons
9ef362bf3d
machinectl: add restart convenience alias ( #30625 )
2023-12-28 07:09:42 +09:00
Yu Watanabe
1a4b0459f6
network/address: unconditionally check if address is ready
...
Previously, we checked if the address is ready only when it is an IPv6
address. But, IPv4 address never enter tentative state, hence the check
for an IPv4 address is effectively equivalent to the one for IPv6.
So, let's unify the check. This does not change any effective behavior.
2023-12-28 07:08:37 +09:00
Yu Watanabe
3a30d81238
Merge pull request #30643 from bluca/completion
...
bash completion additions for systemctl/systemd-analyze
2023-12-28 04:10:20 +09:00
Luca Boccassi
5df839e99f
analyze: allow --no-legend with architectures verb
...
It prints a table with a header, allow omitting it
Follow-up for fb8cc599ed
2023-12-27 17:50:07 +01:00
Mike Yuan
fe33920c2a
sleep: don't log duplicate error
...
write_resume_config() logs error on its own.
2023-12-27 22:38:43 +08:00
Mike Yuan
6e819bd2bd
hibernate-util: remove unused code
...
All callers of write_resume_config() pass non-NULL device.
2023-12-27 22:38:42 +08:00
Mike Yuan
66b9956082
hibernate-util: make sure we use blockdev path for HibernationDevice.path
...
Before this commit, this field could spuriously contain the path of the
swapfile.
2023-12-27 22:38:42 +08:00
Yu Watanabe
51dfa75c6e
Merge pull request #30639 from mrc0mmand/more-cocci-shenanigans
...
Another batch of Coccinelle tweaks
2023-12-27 20:33:46 +09:00
Frantisek Sumsal
321e64dc67
tpm2-util: declare the cleanup attribute first
...
As we do everywhere else (apart from it being incosistent, the switched
order also makes Coccinelle unhappy).
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
8f07111aa8
bootctl: add a missing space
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
b8e0dd3939
test: use timestamp_is_set()
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
cfae9ec203
test: use set_isempty() in one more place
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
6f8b3838c9
test: use IN_SET()/ERRNO_IS_NEG_*() more
2023-12-27 11:15:48 +01:00
Frantisek Sumsal
c83f4220a1
tree-wide: use IN_SET() more
2023-12-27 11:15:48 +01:00
Luca Boccassi
74ce6bbdee
Merge pull request #30631 from yuwata/network-address-free
...
network/address: tiny cleanups for address_free()
2023-12-26 19:21:15 +01:00
Mike Yuan
e14348c616
sleep: connect to correct bus when locking homed-managed homes
...
Partially reverts 122f6f1eaa
Fixes https://github.com/systemd/systemd/issues/29938#issuecomment-1869508708
2023-12-26 18:53:03 +01:00
Yu Watanabe
fe3fcb9492
Merge pull request #30633 from mrc0mmand/cocci-shenanigans
...
coccinelle: rework how we run the Coccinelle transformations
2023-12-26 05:45:58 +09:00
Frantisek Sumsal
8451e720d8
systemctl: use SYNTHETIC_ERRNO()
2023-12-25 19:51:43 +01:00
Frantisek Sumsal
0b3c270896
modules-load: simplify OOM check
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
f2d0e2e5f5
sd-bus: drop unnecessary braces
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
50f605bfe6
network: use timestamp_is_set() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
78bc04cf12
tree-wide: use strndupa_safe() in a couple more cases
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
34e2897f51
nspawn: log & return in a single statement
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
c490b6ddc2
tree-wide: use IOVEC_MAKE() in a couple more places
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
dd1b1dae7e
test: use FLAGS_SET() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
cd1c510f0c
test: use ERRNO_IS_NEG_NOT_SUPPORTED() in one more place
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
6f7936cf57
killall: fix errno check
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
4b68f70829
network: ENOTSUP -> EOPNOTSUPP
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
f51aec74c9
tree-wide: shorten a couple of ternary expressions
2023-12-25 18:26:59 +01:00
Frantisek Sumsal
0a6a59650e
tree-wide: drop !! casts to booleans
2023-12-25 18:26:59 +01:00
Mike Yuan
245841a872
core/unit: don't log 0 values in unit_log_resources
...
Prompted by #30573
2023-12-25 23:19:44 +09:00