SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
34,266 Commits 2 Branches 1 Tag
cfffa385a3dfbd6bccb0961185e17dbfde95d4bb
Commit Graph
21381 Commits
Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek 6978efcffb core/mount-setup: remove part of check which is always true 
f1470e424b removed one check, but missed a similar
one a few lines down.

CID #1390949.
 2018-05-14 08:50:00 +02:00
Yu Watanabe 3ecdd18f87 test: use _cleanup_hashmap_free_ instread of _cleanup_(hashmap_freep) 2018-05-14 14:14:17 +09:00
Yu Watanabe af4fa99d6a core: use _cleanup_set_free_ instread of _cleanup_(set_freep) 2018-05-14 14:13:57 +09:00
Yu Watanabe 1ab436e314 sd-bus: use free_and_strdup() 2018-05-14 14:09:03 +09:00
Zbigniew Jędrzejewski-Szmek 886eaf052d core: remove two unnecessary newlines 2018-05-13 22:08:30 +02:00
Zbigniew Jędrzejewski-Szmek 930c124c3f pid1: do not write invalid utf-8 in error message 
We'd write a sequence that was invalid unicode and this caused the d-bus
connection to be terminated:

$ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1/unit/dbus_2esocket org.freedesktop.systemd1.Unit SubState
s "running"
$ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1/unit/dbus_e2socket org.freedesktop.systemd1.Unit SubState
Remote peer disconnected
$ busctl get-property org.freedesktop.systemd1 /org/freedesktop/systemd1/unit/dbus_e2socket org.freedesktop.systemd1.Unit SubState
(hangs)

Fixes #8978.
 2018-05-13 22:08:30 +02:00
Zbigniew Jędrzejewski-Szmek 7994ac1d85 Rename ratelimit_test to ratelimit_below 
When I see "test", I have to think three times what the return value
means. With "below" this is immediately clear. ratelimit_below(&limit)
sounds almost like English and is imho immediately obvious.

(I also considered ratelimit_ok, but this strongly implies that being under the
limit is somehow better. Most of the times this is true, but then we use the
ratelimit to detect triple-c-a-d, and "ok" doesn't fit so well there.)

C.f. a1bcaa07.
 2018-05-13 22:08:30 +02:00
Zbigniew Jędrzejewski-Szmek 22dd8d350c Use STRLEN in two places 2018-05-13 22:07:37 +02:00
Zbigniew Jędrzejewski-Szmek 9d728570e7 Merge pull request #8968 from yuwata/bus-macro-2 
bus-util: add several macros for defining functions of getting dbus properties
 2018-05-13 19:12:27 +02:00
Yu Watanabe b4152e9be1 test: add tests for unit_name_from_dbus_path() 2018-05-13 18:44:25 +02:00
Zbigniew Jędrzejewski-Szmek 88136bbc98 Merge pull request #8962 from floppym/issue8905 
basic: timezone_is_valid: check for magic bytes "TZif"
 2018-05-13 18:43:11 +02:00
Yu Watanabe 3ff52e8f52 dbus-manager: introduce property_get_{hashmap,set}_size() 2018-05-13 12:21:17 +09:00
Yu Watanabe d1d8547137 dbus-unit: check userdata before obtaining data 2018-05-13 12:21:15 +09:00
Yu Watanabe cb7f88fcf4 dbus-unit: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:13 +09:00
Yu Watanabe 6bfb45bea4 dbus-swap: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:11 +09:00
Yu Watanabe a54f28bc1e dbus-socket: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:09 +09:00
Yu Watanabe f724fd4c25 dbus-mount: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:08 +09:00
Yu Watanabe 23c9a63a98 dbus-manager: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:06 +09:00
Yu Watanabe 019b34cae6 dbus-execute: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:04 +09:00
Yu Watanabe f744776ff8 bus-util: add several macros for defining functions of getting dbus properties 2018-05-13 12:20:51 +09:00
Mike Gilbert 089fb8653f basic: add log_level argument to timezone_is_valid 2018-05-12 15:20:13 -04:00
Zbigniew Jędrzejewski-Szmek fb58b1ad27 Merge pull request #8966 from yuwata/bus-resolve-fallback-dns 
resolve: add bus property for fallback DNS servers
 2018-05-12 18:48:58 +02:00
David Tardon 95f14a3e21 core: use automatic cleanup more 2018-05-12 18:29:41 +02:00
Mike Gilbert a2932d5116 basic: timezone_is_valid: check for magic bytes "TZif" 
Fixes: https://github.com/systemd/systemd/issues/8905
 2018-05-11 14:11:30 -04:00
David Tardon c0a1bfacfe systemd-analyze: make dump work for large # of units 
If there is a large number of units, the size of the generated dump
string can overstep DBus message size limit. So let's pass that string
via a fd.
 2018-05-11 08:11:02 -07:00
Zbigniew Jędrzejewski-Szmek 2407ed7b63 Merge pull request #8924 from yuwata/fix-3682 
resolve: allow whitespaces in the digest
 2018-05-11 11:48:05 +02:00
Yu Watanabe c369f207f0 resolvectl: show current DNS server only when it is set 2018-05-11 16:12:57 +09:00
Yu Watanabe 4b320ac589 resolvectl: show fallback DNS servers by status command 2018-05-11 16:12:17 +09:00
Yu Watanabe ad32ac5397 resolve: introduce FallbackDNS bus property 
This also makes DNS bus property not include the fallback DNS servers.
 2018-05-11 16:03:19 +09:00
Yu Watanabe 26db55f39e network: make route_update() accept NULL 
This also fixes a wrong argument for route_configure().

Fixes #8960.
 2018-05-11 15:43:04 +09:00
Yu Watanabe 27efb52bc6 network: fix indentation 2018-05-11 15:30:39 +09:00
Lennart Poettering 4b93699d65 tmpfiles: remove newline that shouldn't be there 
We should really keep "else" branches together with their "if", hence
drop the double newline here...
 2018-05-11 08:15:33 +02:00
Lennart Poettering cb91deaf77 terminal-util: add a function that shows a pretty separator line 
Follow-up for #8824
 2018-05-11 08:15:33 +02:00
Yu Watanabe 2d2c21afb2 test: do not call alloca() inside the list of arguments 2018-05-11 15:01:35 +09:00
Lennart Poettering e4915c2797 Merge pull request #8953 from yuwata/bus-macro 
core: simplify dbus properties
 2018-05-10 22:51:17 -07:00
Yu Watanabe 1c5873096e test-execute: remove state directories before running tests 
Fixes #8679.
 2018-05-10 22:50:51 -07:00
Yu Watanabe ce088d6fb4 sd-dhcp: drop deserialize_dhcp_option() as it is equivalent to unhexmem() 2018-05-11 14:44:03 +09:00
Yu Watanabe 509685f91a resolve: allow whitespaces in the DS digest or DNSKEY key data 
Fixes #3682.
 2018-05-11 14:36:41 +09:00
Yu Watanabe 9ec578a370 hexdecoct: drop an unnecessary check 2018-05-11 14:36:36 +09:00
Yu Watanabe aba135249e basic: fix comment style 2018-05-11 14:36:32 +09:00
Yu Watanabe 4937b81a7b hexdecoct: ignore whitespace within the input hexadecimal text of unhexmem() 2018-05-11 14:36:22 +09:00
Joost Heitbrink b6887d7ae4 test: add testcase for environment file variables with backslashes 
systemd silently strips out backslashes in variables from environment
files. Add a testcase that explicitly tests for this behaviour.
 2018-05-11 13:15:16 +09:00
Lennart Poettering 81321f51cf Merge pull request #8824 from keszybz/analyze-show-config 
systemd-analyze show-config
 2018-05-10 11:14:23 -07:00
Lennart Poettering 41b9d436b2 mtd: some basic code cleanups 
While looking at our exit() invocations I noticed that the mtd_probe
stuff uses 'exit(-1)' at various places, which is not really a good
idea, as exit codes of processes on Linux are supposed to be in the
range of 0…255.

This patch cleans that up a bit, and fixes a number of other things:

1. Let's always let main() exit, nothing intermediary. We generally
   don't like code that invokes exit() on its own.

2. Close the file descriptors opened.

3. Some logging for errors is added, mostly on debug level.

Please review this with extra care. As I don't have the right hardware
to test this patch I only did superficial testing.
 2018-05-10 11:02:33 -07:00
Yu Watanabe c5984fe177 string-util: rename strdash_if_empty() to empty_to_dash() 2018-05-11 01:55:46 +09:00
Yu Watanabe 945403e6ed path-util: introduce empty_to_root() and use it many places 2018-05-11 01:47:33 +09:00
Yu Watanabe 54138a8de1 core: merge duplicated functions 2018-05-11 01:41:06 +09:00
Yu Watanabe 79a603758d core: send NULL instead of empty string 2018-05-11 01:22:49 +09:00
Yu Watanabe 9d5527f26e core: use offsetof() for Syslog{Level,Facility} dbus properties 2018-05-11 00:39:52 +09:00
Zbigniew Jędrzejewski-Szmek 717fb9bc24 Merge pull request #8950 from dtardon/cleanup 
use automatic cleanup more
 2018-05-10 17:23:40 +02:00