Commit Graph
49437 Commits
Author SHA1 Message Date
Mike Yuan 6d8690ecd3 shared/vpick: align function args correctly, add missing assertion 2024-04-16 01:38:08 +08:00
Yu Watanabe e2f0876ecd dissect: refuse to use diskseq if ID_IGNORE_DISKSEQ=1 is specified
Follow-up for 1a81ddef00.
2024-04-15 16:50:45 +02:00
Lennart Poettering bfbd7ac96a creds: update --help text regarding tpm2-absent → null rename
This was forgotten when "tpm2-absent" was renamed to "null".

Follow-up-for: 6d78dc2827
2024-04-15 15:53:12 +02:00
Sam Leonard c3dd4e20fe vmspawn: generate predicatable TAP device names and MAC addresses 2024-04-15 11:42:06 +01:00
Sam Leonard c50e7dcaf6 nspawn,shared/netif-util: move generate_mac and shorten_ifname to shared/netif-util 2024-04-15 11:42:05 +01:00
Sam Leonard bf3274e880 vmspawn: insert missing empty line 2024-04-15 11:24:27 +01:00
Sam Leonard 7c64382638 vmspawn: sort headers 2024-04-15 11:24:27 +01:00
Ivan Kruglov c79e88b37d ASSERT_STREQ for simple cases 2024-04-15 08:13:50 +02:00
Yu Watanabe 9506269d12 Merge pull request #32266 from yuwata/libsystemd-network-trivial-cleanups
libsystemd-network: trivial cleanups
2024-04-15 14:43:12 +09:00
Yu Watanabe 049bdac7b6 ndisc-option: add missing case
Follow-up for 9f3587ae44.
2024-04-15 14:41:45 +09:00
Yu Watanabe ac336e754e sd-ndisc: make ndisc_send() and icmp6_send() take struct in6_addr
No functional change, just refactoring.
2024-04-15 06:23:11 +09:00
Yu Watanabe 2c28eb0266 libsystemd-network: make constant addresses type-safe
No functional change, just refactoring.
2024-04-15 06:23:11 +09:00
Yu Watanabe dea17a0864 dhcp6-network: constify arguments
No functional change, just refactoring.
2024-04-15 06:23:11 +09:00
Mike Yuan 58ff2f1e38 core/execute: also check cg_is_threaded for clone3()
Prompted by #32259

We already have this check in exec_invoke(), i.e. child.
But if CLONE_INTO_CGROUP is used, the failure would
occur on parent's side, so do the check there too.
2024-04-14 23:22:13 +08:00
Mike Yuan ad68a4e58a core/dbus-manager: rephrase the comment for method_get_unit_processes a bit 2024-04-14 23:22:13 +08:00
Mike Yuan 8a70edc1f7 core/dbus-manager: add missing assertion 2024-04-14 23:22:13 +08:00
Mike Yuan da130b9ab8 cgroup-setup: modernize cg_migrate 2024-04-14 23:22:13 +08:00
Mike Yuan 2d51ea22aa core/unit: use IN_SET at one more place 2024-04-14 23:22:12 +08:00
Yu Watanabe ae9fd433d6 Merge pull request #32194 from henryli001/lihl/add-defaultUseDomains-config
network: add mechanism to configure default UseDomains= setting
2024-04-14 13:40:06 +09:00
Henry Li fb57300743 network: add mechanism to configure default UseDomains= setting, update man page and add test 2024-04-13 16:54:31 -07:00
Yu Watanabe 632d321050 network/tc: fix stack overflow when dropping tclass or qdisc
Fixes a bug introduced by be8e933900 (v255).

Fixes #32247.
Fixes #32254.
2024-04-13 08:49:54 +09:00
Yu Watanabe bffc1a28d5 Merge pull request #32257 from yuwata/tree-wide-trivial-style-fixes
tree-wide: trivial style and typo fixes
2024-04-13 08:02:18 +09:00
Sam Leonard af49ea3371 vmspawn: check firmware target architecture
Fixes issue #32026 by only finding firmwares which explicitly support
the native architecture.
2024-04-13 05:48:05 +09:00
Yu Watanabe 7f5c82aaf3 tree-wide: insert missing space after comma 2024-04-13 05:44:04 +09:00
Yu Watanabe b2da2296ff journal: drop thousands separator in comment 2024-04-13 05:43:37 +09:00
Yu Watanabe 6d3024369e home: wrap long line 2024-04-13 05:42:21 +09:00
Yu Watanabe c133387f7e homectl: realign table 2024-04-13 05:41:46 +09:00
Yu Watanabe 4dbcda1cca network/ndisc: fix typo
Follow-up for e42a74803a.
2024-04-13 05:21:42 +09:00
Yu Watanabe bf4c90caed core: fix typo
Follow-up for 21b366121f.
2024-04-13 05:20:05 +09:00
Evgeny Vereshchagin af6e984109 fuzz: check that resource records are serialized successfully
It shouldn't fail at that point.

It's prompted by the "Structure needs cleaning" thing that keeps popping
up in various places like
https://github.com/systemd/systemd/pull/30952#discussion_r1553181309 and
https://github.com/systemd/systemd/issues/31708.
2024-04-13 05:18:12 +09:00
Yu Watanabe 87bbcb26c8 Merge pull request #32255 from YHNdnzj/strextendf
shared/killall: minor modernization
2024-04-13 05:10:20 +09:00
Mike Yuan d2198b3206 sd-dhcp-server: use close_and_replace (avoid fd leak)
Follow-up for 11b88419ae

Fixes #32252
2024-04-13 02:48:52 +08:00
Mike Yuan 3c321488bc sd-dhcp-server: check dir_fd with assert_return 2024-04-13 02:48:52 +08:00
Mike Yuan bbfb9edc66 shared/killall: minor modernization 2024-04-13 02:35:01 +08:00
Mike Yuan dbbc86ffbd string-util: correct comment in strextendf_with_separator 2024-04-13 02:35:01 +08:00
Sam Leonard edd85c8414 vmspawn: add --discard-disk= to control handling of disk discard requests
Fixes issue #32024, using --discard-disk=yes will enable handling of disk
discarding requests, saving space for long running VMs as desired.
2024-04-12 20:32:38 +02:00
Sam Leonard 0f85622950 vmspawn: update parse_boolean to parse_boolean_argument 2024-04-12 13:26:36 +01:00
Antonio Alvarez Feijoo 126928de76 bus-polkit: fix return value for varlink_allow_interactive_authentication()
Follow-up for d04c1a1c8e
2024-04-12 13:26:22 +01:00
Zbigniew Jędrzejewski-Szmek c71b50179e meson: do not fail build with newer kernel headers
systemd-255 is failing a build with the latest kernel headers… Let's downgrade
this warning, because it's fine if there's a file system we don't know about
and it makes thing less brittle if we don't treat this as a hard error.

(I initially conditionalized this on BUILD_MODE, but I don't think we need a
hard error there either. A warning will be noticed and fixed.)
2024-04-12 11:44:58 +01:00
Yu Watanabe 296afa8477 ndisc-option: also ignore Prefix Information option with multicast address
Fixes https://github.com/systemd/systemd/pull/32215#issuecomment-2049624693
2024-04-12 10:34:12 +01:00
Yu Watanabe b263362254 network/ndisc: drop onlink prefix when valid lifetime is zero
Replaces 155d7a2c04.
2024-04-12 06:12:03 +09:00
Yu Watanabe 9f368d9eb2 network/ndisc: do nothing for existing routes if on-link flag is zero
This effectively reverts commit 155d7a2c04.

From RFC 4861 section 6.3.4:
> Note, however, that a Prefix Information option with the on-link flag
> set to zero conveys no information concerning on-link determination and
> MUST NOT be interpreted to mean that addresses covered by the prefix
> are off-link.

So, we should not drop previously configured routes when receieved a RA
with Prefix Information option without on-link flag.

Closes #28435.
2024-04-12 06:12:03 +09:00
Ronan Pigott 3a768db480 resolved: use NULL to represent an empty answer 2024-04-12 06:10:51 +09:00
Sam Leonard 657be6bdc7 vmspawn: enabled free page reporting in qemu by default
Fixes issue #32025, I saw no reason not to enable this by default so I
added it to the initial qemu cmdline.
2024-04-12 06:10:25 +09:00
Yu Watanabe f87a606e10 Merge pull request #32213 from yuwata/network-ndisc-redirect-fix-sender-address-verification
network/ndisc: fix sender address verification of Redirect message
2024-04-12 06:09:44 +09:00
Ludwig Nussel e7705e2191 nsresourced: don't redefine of bpf_rdonly_cast
bpf_rdonly_cast() was introduced in libbpf commit 688879f together with
the definition of a bpf_core_cast macro. So use that one to avoid
defining a prototype for bpf_rdonly_cast;
2024-04-12 05:55:27 +09:00
Yu Watanabe bffa1c4889 sd-ndisc-redirect: fix verification of target address
See RFC 4861 section 8.1.
2024-04-12 04:59:42 +09:00
Yu Watanabe 9944629eee network/ndisc: fix verification of sender of Redirect message
The sender must be the first-hop router of the destination. Previously,
we only accepted Redirect messages whose sender is the current default
router with the highest priority.

See RFC 4861 section 8.1 for more details.

Fixes #31981.
2024-04-12 04:59:42 +09:00
Yu Watanabe f76814757d network/ndisc: split out ndisc_redirect_verify_sender()
No functional change, preparation for later commits.
2024-04-12 04:59:42 +09:00
Yu Watanabe d9688518ff network/ndisc: drop ndisc_request_redirect_route()
It is now called by only ndisc_redirect_handler(), and the check in
ndisc_request_redirect_route() is redundant and already done by
ndisc_redirect_verify_sender().

No functional change, just refactoring.
2024-04-12 04:59:42 +09:00