SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,843 Commits 2 Branches 1 Tag
e4bb1a07ef834f4e4eabe1fa21e838586e7dd2a3
Commit Graph
57843 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek bac06497fe shared/json: wrap long comments 2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek a2c5735dd8 fuzz-json: also do sorting and normalizing and other easy calls 2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek a4669764f7 shared/json: reduce scope of variables 2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek 9ad955ce40 fuzz-json: optionally allow logging and output 
Similarly to other fuzzers… this makes development easier.
 2022-05-10 12:58:48 +02:00
Zbigniew Jędrzejewski-Szmek 9674b089cf json: align table 2022-05-10 12:58:48 +02:00
Kazuo Moriwaka 6f310287db add missing cleanup-age to quickref 2022-05-10 17:41:21 +09:00
Yu Watanabe 16f74783d8 resolve: reallocate DNS scope when DNSSEC and/or DNS-over-TLS settings are changed 
Fixes #23227.
 2022-05-10 09:44:45 +02:00
Yu Watanabe 81391854ec Merge pull request #23300 from DaanDeMeyer/device-debug 
core/device: Add more logging
 2022-05-10 14:29:35 +09:00
Frantisek Sumsal 624f685fe8 core: annotate Reexecute() as NoReply 
So we're able to tell from the introspection data that the method
doesn't reply.
 2022-05-10 14:16:11 +09:00
Yutsuten ffa3da1dc2 Add HUION Inspiroy H420X to hwdb 2022-05-10 14:14:17 +09:00
Mario Limonciello f32049eda3 Set autosuspend delay for Fibocom LG850-GL 
It has been shown that the autosuspend delay for this device enacted
by modem manager will race with suspend and cause system suspend
failures.

This occurred in ChromiumOS on a chromebook, but there is no reason
it won't happen in regular notebooks with the same WWAN.  To avoid
the failure delay autosuspend to a frequency longer than the polling
rate used by modem manager.

Link: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/3635003
Link: https://github.com/freedesktop/ModemManager/blob/43e76bf1bbca8207e37d3fbddfed4bb8578f0170/src/mm-iface-modem.c#L1633
 2022-05-09 21:14:12 -05:00
Mario Limonciello fa9a43a690 Add support to set autosuspend delay via hwdb 2022-05-09 21:14:12 -05:00
Yu Watanabe 31090c17f4 Merge pull request #23321 from poettering/sockaddr-no-cast 
tests: avoid sockaddr casts
 2022-05-09 23:44:01 +09:00
Yu Watanabe d171e72e7a core/slice: make slice_freezer_action() return 0 if freezing state is unchanged 
Fixes #23278.
 2022-05-09 23:43:32 +09:00
Luca Boccassi 37b7eef35d mkosi: add shadow package to SUSE Tumbleweed 
[1958/1958] Generating export-dbus-interfaces with a custom command
/root/mkosi.build: line 70: groupadd: command not found
 2022-05-09 14:58:06 +01:00
Lennart Poettering f9a1fd2a3b test: JSON_BUILD_REAL nowadays expects 'double', not 'long double' 
Follow-up for 337712e777, aka "the great
un-long-double-ification of 2021".
 2022-05-09 14:32:31 +02:00
Lennart Poettering 3bf175f076 tests: avoid (struct sockaddr*) casts 
We prefer using using union sockaddr_union instead of casting sockaddr
to the correct types.

Coding style, nothing else.

Follow-up for 0dd5ec58fa.
 2022-05-09 13:56:39 +02:00
Lennart Poettering b501e42e71 socket-util: don't reference field by macro parameter name 
Let's avoid ambigituies here. (Interesting that the current users
compiled at all, in fact)
 2022-05-09 13:55:28 +02:00
Lennart Poettering 3a466defd4 update TODO 2022-05-09 12:17:08 +02:00
Yu Watanabe a6b084234c network: set/unset enumerating flag before/after loop 2022-05-09 18:59:24 +09:00
Daan De Meyer 2aaf6d407e shared: Fix memory leak in bus_append_execute_property() 
Fixes #23317
 2022-05-09 18:58:55 +09:00
Yu Watanabe df423851fc Merge pull request #23310 from keszybz/suppress-fuzzer-timeouts-and-errors 
Suppress fuzzer timeouts and errors
 2022-05-09 15:50:29 +09:00
Yu Watanabe b5be9dbebf Merge pull request #23311 from keszybz/bootspec-fuzzer 
Fuzzer for bootspec.c and associated fixes
 2022-05-09 15:46:49 +09:00
Zbigniew Jędrzejewski-Szmek 3947432eb0 shared/calendarspec: reduce scope of variables 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek 68ac5118e7 shared/dissect-image: apply standard indentation 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek a9d178d28b basic/virt: use STRV_FOREACH instead of iteration with ELEMENTSOF 
I think it's a bit simpler, we don't have two indexes.
 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek c9c3b81f12 libsystemd-network: constify casts 
It is better to not drop the const-ness from the argument.
 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek 2034c8b883 tree-wide: drop de-constifying casts for strv iteration 
When the the iterator variable is declared automatically, it "inherits" the
const/non-const status from the argument. We don't need to cast a const
table to non-const. If we had a programming error and tried to modify the
string, the compiler could now catch this.
 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek 40893cbfd5 fuzz-journal-remote: allow -ENODATA too 
It seems that we try to create a new file, which fails with -ENOSPC, and we
later fail when reading a file with ENODATA.  journal_file_open() will return
-ENODATA if the file is too short or if journal_file_verify_header() fails.
We'll unlink a file we newly created if we fail to initialize it immediately
after creation. I'm not sure if the file we fail to open is the one we newly
created and e.g. failed to create the arena and such, or if it's the file we
were trying to rotate away from. Either way, I think we should be OK with
with a non-fully-initialized journal file.

Failed to create rotated journal: No space left on device
Failed to write entry of 2 bytes: No space left on device
sd_journal_open_files(["/tmp/fuzz-journal-remote.vELRpI.journal"]) failed: No data available
Assertion 'IN_SET(r, -ENOMEM, -EMFILE, -ENFILE)' failed at src/journal-remote/fuzz-journal-remote.c:70, function int LLVMFuzzerTestOneInput(const uint8_t *, size_t)(). Aborting.

oss-fuzz-39238: https://oss-fuzz.com/issue/4609851129462784
 2022-05-08 22:47:50 +02:00
Zbigniew Jędrzejewski-Szmek 44468876c3 fuzz-systemctl-parse-argv: refuse commandlines above 1k entries 
oss-fuzz reports timeouts which are created by appending to a very long strv.
The code is indeed not very efficient, but it's designed for normal
command-line use, where we don't expect more than a dozen of entries. The fact
that it is slow with ~100k entries is not particularly interesting.

In the future we could rework the code to have better algorithmic complexity.
But let's at least stop oss-fuzz from wasting more time on such examples.

(My first approach was to set max_len in .options, but apparently this doesn't
work for hongfuzz and and AFL.)

oss-fuzz-34527: https://oss-fuzz.com/issue/5722283944574976
 2022-05-08 22:47:50 +02:00
Yu Watanabe 734582830b core/unit: fix use-after-free 
Fixes #23312.
 2022-05-08 22:45:07 +02:00
Zbigniew Jędrzejewski-Szmek d4f72d104f shared/bootspec: add missing terminator to table 2022-05-08 17:58:00 +02:00
Zbigniew Jędrzejewski-Szmek a89dd095e1 fuzz-bootspec: also add loader autoentries 2022-05-08 17:58:00 +02:00
Zbigniew Jędrzejewski-Szmek 13dcfbd32d fuzz-bootspec: one more test case that was fixed in strv code 2022-05-08 17:58:00 +02:00
Zbigniew Jędrzejewski-Szmek b6bd2562eb shared/bootspec: avoid crashing on config without a value 2022-05-08 17:58:00 +02:00
Zbigniew Jędrzejewski-Szmek 1409ce6ed2 Add fuzzer for the bootspec parser 2022-05-08 17:58:00 +02:00
Zbigniew Jędrzejewski-Szmek a847b539de shared/bootspec: also export boot_config_load_type1() 
The reallocation of memory and counter incrementation is moved from
the only caller to the function. This way the callers can remain oblivious
of the BootConfig internals.
 2022-05-08 17:57:57 +02:00
Zbigniew Jędrzejewski-Szmek 5ba1550fd8 shared/bootspec: expose more parts of the config parsing 2022-05-08 17:56:12 +02:00
Zbigniew Jędrzejewski-Szmek 432ce53737 Move printing of boot entries from bootctl.c to shared/ 
I want to use this for fuzzing, but also later to return jsonified
list of entries from logind.
 2022-05-08 17:55:03 +02:00
Zbigniew Jędrzejewski-Szmek ec725c0c49 shared/bootspec: add one more assert 
All callers assume that boot_entry_title() always returns something.
It will, as long as it's not called on an uninitialized entry.
 2022-05-08 17:53:56 +02:00
Zbigniew Jędrzejewski-Szmek 91da36f195 meson: sort list of fuzzers 2022-05-08 17:53:56 +02:00
Zbigniew Jędrzejewski-Szmek c04361d725 docs/ARCHITECTURE: describe fuzzer locations and use 2022-05-08 17:53:56 +02:00
Zbigniew Jędrzejewski-Szmek 7f5b2615a7 dissect: drop unnecessary {} 2022-05-08 16:23:13 +02:00
Yu Watanabe 4e5f4733c5 bash-completion: resolvectl: add missing options and verb 2022-05-08 14:14:28 +02:00
Daan De Meyer c189f91f1f core/device: Add logging to device_is_ready() 2022-05-08 13:25:42 +02:00
Daan De Meyer f0fdcb8cfa core/device: Improve device_dispatch_io() logging messages 2022-05-08 13:25:42 +02:00
Daan De Meyer c34511086f core/device: Log when we can't retrieve SYSTEMD_ALIAS property 2022-05-08 13:25:42 +02:00
Daan De Meyer 2f82874558 core/device: Log when we skip device unit creation for symlink 2022-05-08 13:25:42 +02:00
Daan De Meyer e9222bfcfa core/device: Log if we fail to open a device 
We also shorten the logic by getting rid of the validate_node()
function. An extra check is added to verify we're dealing with
a device before calling sd_device_new_from_devname() since that
will return -EINVAL if anything other than a device is passed.
 2022-05-08 13:25:42 +02:00
Daan De Meyer 6cc4da5eb5 core/device: Log on every event received from udev 
We already debug log on device unit state changes but additionally,
let's debug log for every event received from udev as well.
 2022-05-08 13:25:39 +02:00