Zbigniew Jędrzejewski-Szmek
254d1313ae
-1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary.
79 lines
4.0 KiB
C
79 lines
4.0 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include "alloc-util.h"
|
|
#include "fd-util.h"
|
|
#include "fileio.h"
|
|
#include "fs-util.h"
|
|
#include "parse-util.h"
|
|
#include "psi-util.h"
|
|
#include "tests.h"
|
|
#include "tmpfile-util.h"
|
|
|
|
TEST(read_mem_pressure) {
|
|
_cleanup_(unlink_tempfilep) char path[] = "/tmp/pressurereadtestXXXXXX";
|
|
_cleanup_close_ int fd = -EBADF;
|
|
ResourcePressure rp;
|
|
|
|
if (geteuid() != 0)
|
|
return (void) log_tests_skipped("not root");
|
|
|
|
assert_se((fd = mkostemp_safe(path)) >= 0);
|
|
|
|
assert_se(read_resource_pressure("/verylikelynonexistentpath", PRESSURE_TYPE_SOME, &rp) < 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) < 0);
|
|
|
|
assert_se(write_string_file(path, "herpdederp\n", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) < 0);
|
|
|
|
/* Pressure file with some invalid values */
|
|
assert_se(write_string_file(path, "some avg10=0.22=55 avg60=0.17=8 avg300=1.11=00 total=58761459\n"
|
|
"full avg10=0.23=55 avg60=0.16=8 avg300=1.08=00 total=58464525", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) < 0);
|
|
|
|
/* Same pressure valid values as below but with duplicate avg60 field */
|
|
assert_se(write_string_file(path, "some avg10=0.22 avg60=0.17 avg60=0.18 avg300=1.11 total=58761459\n"
|
|
"full avg10=0.23 avg60=0.16 avg300=1.08 total=58464525", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) < 0);
|
|
|
|
assert_se(write_string_file(path, "some avg10=0.22 avg60=0.17 avg300=1.11 total=58761459\n"
|
|
"full avg10=0.23 avg60=0.16 avg300=1.08 total=58464525", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) == 0);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg10) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg10) == 22);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg60) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg60) == 17);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg300) == 1);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg300) == 11);
|
|
assert_se(rp.total == 58761459);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_FULL, &rp) == 0);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg10) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg10) == 23);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg60) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg60) == 16);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg300) == 1);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg300) == 8);
|
|
assert_se(rp.total == 58464525);
|
|
|
|
/* Pressure file with extra unsupported fields */
|
|
assert_se(write_string_file(path, "some avg5=0.55 avg10=0.22 avg60=0.17 avg300=1.11 total=58761459\n"
|
|
"full avg10=0.23 avg60=0.16 avg300=1.08 avg600=2.00 total=58464525", WRITE_STRING_FILE_CREATE) == 0);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_SOME, &rp) == 0);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg10) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg10) == 22);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg60) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg60) == 17);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg300) == 1);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg300) == 11);
|
|
assert_se(rp.total == 58761459);
|
|
assert_se(read_resource_pressure(path, PRESSURE_TYPE_FULL, &rp) == 0);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg10) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg10) == 23);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg60) == 0);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg60) == 16);
|
|
assert_se(LOADAVG_INT_SIDE(rp.avg300) == 1);
|
|
assert_se(LOADAVG_DECIMAL_SIDE(rp.avg300) == 8);
|
|
assert_se(rp.total == 58464525);
|
|
}
|
|
|
|
DEFINE_TEST_MAIN(LOG_DEBUG);
|