Mike Yuan
b8df25dcfe
Added in https://github.com/torvalds/linux/commit/6140be90ec70c39fa844741ca3cc807dd0866394 However, when O_PATH fds are encountered we'd have to go by /proc/self/fd/ still, since the kernel people are reluctant to make the new syscalls work with them (https://lore.kernel.org/linux-fsdevel/20250206-steril-raumplanung-733224062432@brauner/) Hence getxattrat() and listxattrat() are not employed. While at it, remove the discrepancy between path being NULL and empty - I don't grok the "security issue" claimed earlier, but nowadays even the kernel treats the two as identical: https://github.com/torvalds/linux/commit/e896474fe4851ffc4dd860c92daa906783090346
137 lines
4.4 KiB
C
137 lines
4.4 KiB
C
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <sys/types.h>
|
|
#include <sys/xattr.h>
|
|
#include <unistd.h>
|
|
|
|
#include "alloc-util.h"
|
|
#include "fd-util.h"
|
|
#include "fs-util.h"
|
|
#include "macro.h"
|
|
#include "rm-rf.h"
|
|
#include "string-util.h"
|
|
#include "tests.h"
|
|
#include "tmpfile-util.h"
|
|
#include "xattr-util.h"
|
|
|
|
TEST(getxattr_at_malloc) {
|
|
_cleanup_(rm_rf_physical_and_freep) char *t = NULL;
|
|
_cleanup_free_ char *value = NULL;
|
|
_cleanup_close_ int fd = -EBADF;
|
|
const char *x;
|
|
int r;
|
|
|
|
fd = mkdtemp_open("/var/tmp/test-xattrtestXXXXXX", O_RDONLY|O_NOCTTY, &t);
|
|
assert_se(fd >= 0);
|
|
x = strjoina(t, "/test");
|
|
assert_se(touch(x) >= 0);
|
|
|
|
r = setxattr(x, "user.foo", "bar", 3, 0);
|
|
if (r < 0 && ERRNO_IS_NOT_SUPPORTED(errno))
|
|
return (void) log_tests_skipped_errno(errno, "no xattrs supported on /var/tmp");
|
|
assert_se(r >= 0);
|
|
|
|
assert_se(getxattr_at_malloc(fd, "test", "user.foo", 0, &value) == 3);
|
|
assert_se(memcmp(value, "bar", 3) == 0);
|
|
value = mfree(value);
|
|
|
|
assert_se(getxattr_at_malloc(AT_FDCWD, x, "user.foo", 0, &value) == 3);
|
|
assert_se(memcmp(value, "bar", 3) == 0);
|
|
value = mfree(value);
|
|
|
|
safe_close(fd);
|
|
fd = open("/", O_RDONLY|O_DIRECTORY|O_CLOEXEC|O_NOCTTY);
|
|
assert_se(fd >= 0);
|
|
r = getxattr_at_malloc(fd, "usr", "user.idontexist", 0, &value);
|
|
assert_se(ERRNO_IS_NEG_XATTR_ABSENT(r));
|
|
|
|
safe_close(fd);
|
|
fd = open(x, O_PATH|O_CLOEXEC);
|
|
assert_se(fd >= 0);
|
|
assert_se(getxattr_at_malloc(fd, NULL, "user.foo", 0, &value) == 3);
|
|
ASSERT_STREQ(value, "bar");
|
|
}
|
|
|
|
TEST(getcrtime) {
|
|
_cleanup_(rm_rf_physical_and_freep) char *t = NULL;
|
|
_cleanup_close_ int fd = -EBADF;
|
|
usec_t usec, k;
|
|
int r;
|
|
|
|
fd = mkdtemp_open("/var/tmp/test-xattrtestXXXXXX", 0, &t);
|
|
assert_se(fd >= 0);
|
|
|
|
r = fd_getcrtime(fd, &usec);
|
|
if (r < 0)
|
|
log_debug_errno(r, "btime: %m");
|
|
else
|
|
log_debug("btime: %s", FORMAT_TIMESTAMP(usec));
|
|
|
|
k = now(CLOCK_REALTIME);
|
|
|
|
r = fd_setcrtime(fd, 1519126446UL * USEC_PER_SEC);
|
|
if (!IN_SET(r, -EOPNOTSUPP, -ENOTTY)) {
|
|
assert_se(fd_getcrtime(fd, &usec) >= 0);
|
|
assert_se(k < 1519126446UL * USEC_PER_SEC ||
|
|
usec == 1519126446UL * USEC_PER_SEC);
|
|
}
|
|
}
|
|
|
|
static void verify_xattr(int dfd, const char *expected) {
|
|
_cleanup_free_ char *value = NULL;
|
|
|
|
ASSERT_OK_EQ(getxattr_at_malloc(dfd, "test", "user.foo", 0, &value), (int) strlen(expected));
|
|
ASSERT_STREQ(value, expected);
|
|
}
|
|
|
|
TEST(xsetxattr) {
|
|
_cleanup_(rm_rf_physical_and_freep) char *t = NULL;
|
|
_cleanup_close_ int dfd = -EBADF, fd = -EBADF;
|
|
const char *x;
|
|
int r;
|
|
|
|
dfd = mkdtemp_open("/var/tmp/test-xattrtestXXXXXX", O_PATH, &t);
|
|
assert_se(dfd >= 0);
|
|
x = strjoina(t, "/test");
|
|
assert_se(touch(x) >= 0);
|
|
|
|
/* by full path */
|
|
r = xsetxattr(AT_FDCWD, x, 0, "user.foo", "fullpath");
|
|
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
|
|
return (void) log_tests_skipped_errno(r, "no xattrs supported on /var/tmp");
|
|
ASSERT_OK(r);
|
|
verify_xattr(dfd, "fullpath");
|
|
|
|
/* by dirfd */
|
|
ASSERT_ERROR(xsetxattr_full(dfd, "test", 0, "user.foo", "dirfd", SIZE_MAX, XATTR_CREATE), EEXIST);
|
|
verify_xattr(dfd, "fullpath");
|
|
|
|
ASSERT_OK(xsetxattr_full(dfd, "test", 0, "user.foo", "dirfd", SIZE_MAX, XATTR_REPLACE));
|
|
verify_xattr(dfd, "dirfd");
|
|
|
|
/* by fd (O_PATH) */
|
|
ASSERT_OK_ERRNO(fd = openat(dfd, "test", O_PATH|O_CLOEXEC));
|
|
|
|
ASSERT_OK(xremovexattr(fd, "", 0, "user.foo"));
|
|
|
|
ASSERT_OK(xsetxattr_full(fd, NULL, AT_EMPTY_PATH, "user.foo", "fd_opath", SIZE_MAX, XATTR_CREATE));
|
|
verify_xattr(dfd, "fd_opath");
|
|
|
|
ASSERT_OK(xsetxattr(fd, "", 0, "user.foo", "fd_opath_empty"));
|
|
verify_xattr(dfd, "fd_opath_empty");
|
|
|
|
fd = safe_close(fd);
|
|
|
|
fd = openat(dfd, "test", O_RDONLY|O_CLOEXEC);
|
|
|
|
ASSERT_OK(xsetxattr_full(fd, NULL, 0, "user.foo", "fd_regular", SIZE_MAX, XATTR_REPLACE));
|
|
verify_xattr(dfd, "fd_regular");
|
|
|
|
ASSERT_OK(xsetxattr(fd, "", 0, "user.foo", "fd_regular_empty"));
|
|
verify_xattr(dfd, "fd_regular_empty");
|
|
}
|
|
|
|
DEFINE_TEST_MAIN(LOG_DEBUG);
|