SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests,sms: print PDUs only on verbose test mode

Browse Source 
Therefore, avoid needing TEST_SMS_PART_ENABLE_TRACE build symbol.
This commit is contained in:
Aleksander Morgado
2019-10-14 15:30:03 +02:00
parent 3b18d21ba5
commit 03223fe786
2 changed files with 34 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tests/test-sms-part-3gpp.c
+17 -18
View File
@@ -26,23 +26,6 @@
#include "mm-sms-part-3gpp.h"
#include "mm-log.h"
/* If defined will print debugging traces */
#ifdef TEST_SMS_PART_ENABLE_TRACE
#define trace_pdu(pdu, pdu_len) do { \
guint i; \
\
g_print ("\n "); \
for (i = 0; i < len; i++) { \
g_print (" 0x%02X", pdu[i]); \
if (((i + 1) % 12) == 0) \
g_print ("\n "); \
} \
g_print ("\n"); \
} while (0)
#else
#define trace_pdu(...)
#endif
/********************* PDU PARSER TESTS *********************/
static void
@@ -508,6 +491,21 @@ test_address_encode_unknown (void)
/********************* PDU CREATOR TESTS *********************/
static void
trace_pdu (const guint8 *pdu,
guint len)
{
guint i;
g_print ("n ");
for (i = 0; i < len; i++) {
g_print (" 0x%02X", pdu[i]);
if (((i + 1) % 12) == 0)
g_print ("n ");
}
g_print ("n");
}
static void
common_test_create_pdu (const gchar *smsc,
const gchar *number,
@@ -549,7 +547,8 @@ common_test_create_pdu (const gchar *smsc,
&error);
mm_sms_part_free (part);
trace_pdu (pdu, len);
if (g_test_verbose ())
trace_pdu (pdu, len);
g_assert_no_error (error);
g_assert (pdu != NULL);
src/tests/test-sms-part-cdma.c
+17 -18
View File
@@ -25,23 +25,6 @@
#include "mm-sms-part-cdma.h"
#include "mm-log.h"
/* If defined will print debugging traces */
#ifdef TEST_SMS_PART_ENABLE_TRACE
#define trace_pdu(pdu, pdu_len) do { \
guint i; \
\
g_print ("\n "); \
for (i = 0; i < len; i++) { \
g_print (" 0x%02X", pdu[i]); \
if (((i + 1) % 12) == 0) \
g_print ("\n "); \
} \
g_print ("\n"); \
} while (0)
#else
#define trace_pdu(...)
#endif
/********************* PDU PARSER TESTS *********************/
static void
@@ -369,6 +352,21 @@ test_unicode_encoding (void)
/********************* PDU CREATOR TESTS *********************/
static void
trace_pdu (const guint8 *pdu,
guint len)
{
guint i;
g_print ("n ");
for (i = 0; i < len; i++) {
g_print (" 0x%02X", pdu[i]);
if (((i + 1) % 12) == 0)
g_print ("n ");
}
g_print ("n");
}
static void
common_test_create_pdu (MMSmsCdmaTeleserviceId teleservice_id,
const gchar *number,
@@ -401,7 +399,8 @@ common_test_create_pdu (MMSmsCdmaTeleserviceId teleservice_id,
pdu = mm_sms_part_cdma_get_submit_pdu (part, &len, &error);
mm_sms_part_free (part);
trace_pdu (pdu, len);
if (g_test_verbose ())
trace_pdu (pdu, len);
g_assert_no_error (error);
g_assert (pdu != NULL);