Revert "ublox/helpers: fix propagation of +URAT response parse error"

Not quite correct -- with the patch applied, the newly allocated GError could potentially overwrite inner_error that was set previously. This reverts commit d550a24ffdae4492e9f9e18fdf294adcda28fb65.
2024-07-09 14:55:30 +00:00
parent 26f36f79c9
commit 0365f9f0d8
1 changed files with 5 additions and 4 deletions
@@ -1813,13 +1813,14 @@ mm_ublox_parse_urat_read_response (const gchar  *response,
    }

 out:
+    if (inner_error) {
+        g_propagate_error (error, inner_error);
+        return FALSE;
+    }
+
    if (allowed == MM_MODEM_MODE_NONE) {
        inner_error = g_error_new (MM_CORE_ERROR, MM_CORE_ERROR_FAILED,
                                   "Couldn't parse +URAT response: %s", response);
-    }
-
-    if (inner_error) {
-        g_propagate_error (error, inner_error);
        return FALSE;
    }