SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-modem-qmi: plug memleak when changing current firmware

Browse Source 
==80079== 104 (40 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 4,761 of 5,232
  ==80079==    at 0x483977F: malloc (vg_replace_malloc.c:309)
  ==80079==    by 0x5025AE9: g_malloc (in /usr/lib/libglib-2.0.so.0.6400.2)
  ==80079==    by 0x5006223: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.6400.2)
  ==80079==    by 0x505B0F4: g_array_sized_new (in /usr/lib/libglib-2.0.so.0.6400.2)
  ==80079==    by 0x2008A3: firmware_change_current (mm-broadband-modem-qmi.c:8426)
  ==80079==    by 0x1AB5F3: select_auth_ready (mm-iface-modem-firmware.c:225)
  ==80079==    by 0x4E68653: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
  ==80079==    by 0x4E6DA26: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
  ==80079==    by 0x17402E: authorize_ready (mm-base-modem.c:1363)
  ==80079==    by 0x4E68653: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
  ==80079==    by 0x4E6DA26: ??? (in /usr/lib/libgio-2.0.so.0.6400.2)
  ==80079==    by 0x15366D: check_authorization_ready (mm-auth-provider.c:99)
This commit is contained in:
Aleksander Morgado
2020-06-01 15:28:52 +02:00
parent d848b10d24
commit 10648f8d36
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-broadband-modem-qmi.c
+2
View File
@@ -8429,6 +8429,8 @@ firmware_change_current (MMIfaceModemFirmware *_self,
input = qmi_message_dms_set_firmware_preference_input_new ();
qmi_message_dms_set_firmware_preference_input_set_list (input, array, NULL);
g_array_unref (array);
qmi_client_dms_set_firmware_preference (
QMI_CLIENT_DMS (client),
input,