Add guards to public functions to validate passed arguments.
This commit is contained in:
@@ -84,6 +84,9 @@ mm_serial_parser_v0_parse (gpointer data,
|
||||
int code;
|
||||
gboolean found;
|
||||
|
||||
g_return_val_if_fail (parser != NULL, FALSE);
|
||||
g_return_val_if_fail (response != NULL, FALSE);
|
||||
|
||||
found = g_regex_match_full (parser->generic_response, response->str, response->len, 0, 0, &match_info, NULL);
|
||||
if (found) {
|
||||
str = g_match_info_fetch (match_info, 1);
|
||||
@@ -154,6 +157,8 @@ mm_serial_parser_v0_destroy (gpointer data)
|
||||
{
|
||||
MMSerialParserV0 *parser = (MMSerialParserV0 *) data;
|
||||
|
||||
g_return_if_fail (parser != NULL);
|
||||
|
||||
g_regex_unref (parser->generic_response);
|
||||
g_regex_unref (parser->detailed_error);
|
||||
|
||||
@@ -196,6 +201,9 @@ mm_serial_parser_v1_parse (gpointer data,
|
||||
int code;
|
||||
gboolean found = FALSE;
|
||||
|
||||
g_return_val_if_fail (parser != NULL, FALSE);
|
||||
g_return_val_if_fail (response != NULL, FALSE);
|
||||
|
||||
/* First, check for successfule responses */
|
||||
|
||||
found = g_regex_match_full (parser->regex_ok, response->str, response->len, 0, 0, NULL, NULL);
|
||||
@@ -276,6 +284,8 @@ mm_serial_parser_v1_destroy (gpointer data)
|
||||
{
|
||||
MMSerialParserV1 *parser = (MMSerialParserV1 *) data;
|
||||
|
||||
g_return_if_fail (parser != NULL);
|
||||
|
||||
g_regex_unref (parser->regex_ok);
|
||||
g_regex_unref (parser->regex_connect);
|
||||
g_regex_unref (parser->regex_detailed_error);
|
||||
|
||||
@@ -27,6 +27,9 @@ mm_util_strip_string (GString *string,
|
||||
gboolean matches;
|
||||
char *str;
|
||||
|
||||
g_return_if_fail (string != NULL);
|
||||
g_return_if_fail (regex != NULL);
|
||||
|
||||
matches = g_regex_match_full (regex, string->str, string->len, 0, 0, &match_info, NULL);
|
||||
if (callback) {
|
||||
while (g_match_info_matches (match_info)) {
|
||||
|
||||
Reference in New Issue
Block a user