broadband-modem-qmi: log reason of QMI port open failure

If ModemManager fails to open a QMI port with data format update, it
retries without update. It would be useful to log the reason why the
first try failed; for example on RHEL 7.6 ModemManager fails to write
to sysfs due to SELinux. With this commit, the following message would
be logged:

 <debug> QMI port open operation finished
 <debug> Couldn't open QMI port with data format update: Expected data
 format not updated properly: Failed to open file
 '/sys/class/net/wwp0s29u1u2i8/qmi/raw_ip' for R/W: Permission denied
 <debug> Opening QMI device...

instead of just:

 <debug> QMI port open operation finished
 <debug> Opening QMI device...

While at it, also fix the GError leak.
This commit is contained in:
Beniamino Galvani
2019-02-15 15:03:35 +01:00
parent bf0b5a07ca
commit 35d84ac840
+2
View File
@@ -8422,6 +8422,8 @@ qmi_port_open_ready (MMPortQmi *qmi,
* try without it. The qmi_wwan driver will fix up any issues that
* the device might have between raw-ip and 802.3 mode anyway.
*/
mm_dbg ("Couldn't open QMI port with data format update: %s", error->message);
g_error_free (error);
mm_port_qmi_open (ctx->qmi,
FALSE,
NULL,