SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ublox: ignore error when disconnecting last LTE bearer

Browse Source 
This is required in the TOBY-L2 and TOBY-L4 modules in order to report
a proper disconnection, even if there is none in reality. The default
LTE bearer is always reported connected while registered in LTE.

Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/166
This commit is contained in:
Aleksander Morgado
2019-12-16 14:39:22 +01:00
parent f157d02fc6
commit 7d1e949137
1 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/ublox/mm-broadband-bearer-ublox.c
+28 -4
View File
@@ -670,10 +670,34 @@ cgact_deactivate_ready (MMBaseModem *modem,
GError *error = NULL;
response = mm_base_modem_at_command_finish (modem, res, &error);
if (!response)
g_task_return_error (task, error);
else
g_task_return_boolean (task, TRUE);
if (!response) {
/* TOBY-L4 and TOBY-L2 L2 don't allow to disconnect the last LTE bearer
* as that would imply de-registration from the LTE network, so we just
* assume that it's disconnected from the user point of view.
*
* TOBY-L4 reports this as a generic unknown Packet Domain Error, which
* is a bit unfortunate:
* AT+CGACT=0,1
* +CME ERROR: 148
*
* TOBY-L2 reports this as "LAST PDN disconnection not allowed" but using
* the legacy numeric value before 3GPP Rel 11 (i.e. 151 instead of 171).
* AT+CGACT=0,1
* +CME ERROR: 151
*/
if (!g_error_matches (error, MM_MOBILE_EQUIPMENT_ERROR, MM_MOBILE_EQUIPMENT_ERROR_GPRS_UNKNOWN) &&
!g_error_matches (error, MM_MOBILE_EQUIPMENT_ERROR, MM_MOBILE_EQUIPMENT_ERROR_GPRS_LAST_PDN_DISCONNECTION_NOT_ALLOWED) &&
!g_error_matches (error, MM_MOBILE_EQUIPMENT_ERROR, MM_MOBILE_EQUIPMENT_ERROR_GPRS_LAST_PDN_DISCONNECTION_NOT_ALLOWED_LEGACY)) {
g_task_return_error (task, error);
g_object_unref (task);
return;
}
mm_dbg ("ignored error when disconnecting last LTE bearer: %s", error->message);
g_clear_error (&error);
}
g_task_return_boolean (task, TRUE);
g_object_unref (task);
}