SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ublox: fix loop looking for a specific 4g band value

Browse Source 
We cannot have the ubandsel value comparision inside the for(;;) stop
conditions, because that would mean the loop would stop whenever the
comparison fails. We want to look for a value, so we need to loop the
whole array and stop once we find it only.
This commit is contained in:
Aleksander Morgado
2019-01-30 12:10:03 +01:00
parent 36b5e1ee20
commit 8b9053822b
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/ublox/mm-modem-helpers-ublox.c
+11 -6
View File
@@ -1208,13 +1208,18 @@ append_bands (GArray *bands,
band = MM_MODEM_BAND_UNKNOWN;
if (mode & MM_MODEM_MODE_4G) {
for (j = 0; ubandsel_value == num_bands_4g[j].num && j < G_N_ELEMENTS (num_bands_4g); j++) {
for (k = 0; k < 5; k++) {
band = num_bands_4g[j].band[k];
for (x = 0; (band_configuration[i].bands_4g[x] == band) && (x < G_N_ELEMENTS (band_configuration[i].bands_4g)); x++) {
g_array_append_val (bands, band);
break;
for (j = 0; j < G_N_ELEMENTS (num_bands_4g); j++) {
if (ubandsel_value == num_bands_4g[j].num) {
for (k = 0; k < 5; k++) {
band = num_bands_4g[j].band[k];
for (x = 0; x < G_N_ELEMENTS (band_configuration[i].bands_4g); x++) {
if (band_configuration[i].bands_4g[x] == band) {
g_array_append_val (bands, band);
break;
}
}
}
break;
}
}
}