SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cinterion: fix band related unit tests

Browse Source 
The sort_band() method used in the tester was totally wrong, it was
comparing the addresses of the variables instead of the MMModemBand
values.

Use the common mm_common_bands_garray_sort() instead, which works as
expected.
This commit is contained in:
Aleksander Morgado
2018-07-31 00:23:25 +02:00
parent 3a4a137de3
commit b8c7773a74
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/cinterion/tests/test-modem-helpers-cinterion.c
+4 -10
View File
@@ -25,12 +25,6 @@
#include "mm-modem-helpers.h"
#include "mm-modem-helpers-cinterion.h"
static gint
sort_band (MMModemBand a, MMModemBand b)
{
return a - b;
}
/*****************************************************************************/
/* Test ^SCFG test responses */
@@ -52,8 +46,8 @@ common_test_scfg (const gchar *response,
g_assert (res == TRUE);
g_assert (bands != NULL);
g_array_sort (bands, (GCompareFunc)sort_band);
g_array_sort (expected_bands, (GCompareFunc)sort_band);
mm_common_bands_garray_sort (bands);
mm_common_bands_garray_sort (expected_bands);
expected_bands_str = mm_common_build_bands_string ((const MMModemBand *)expected_bands->data,
expected_bands->len);
@@ -205,8 +199,8 @@ common_test_scfg_response (const gchar *response,
g_assert (res == TRUE);
g_assert (bands != NULL);
g_array_sort (bands, (GCompareFunc)sort_band);
g_array_sort (expected_bands, (GCompareFunc)sort_band);
mm_common_bands_garray_sort (bands);
mm_common_bands_garray_sort (expected_bands);
expected_bands_str = mm_common_build_bands_string ((const MMModemBand *)expected_bands->data,
expected_bands->len);