SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

telit: fix crash if AT$GPSP=? is supported but no GPS data port

Browse Source 
We would have been de-referencing a NULL GError.
This commit is contained in:
Aleksander Morgado
2019-10-31 15:14:27 +01:00
parent 5def58d327
commit e0f0d62369
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/telit/mm-broadband-modem-telit.c
+4 -4
View File
@@ -342,14 +342,14 @@ gpsp_test_ready (MMIfaceModemLocation *self,
sources = GPOINTER_TO_UINT (g_task_get_task_data (task));
mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, &error);
if (!error && mm_base_modem_get_port_gps (MM_BASE_MODEM (self)))
if (error) {
mm_dbg ("telit: GPS controller not supported: %s", error->message);
g_clear_error (&error);
} else if (mm_base_modem_get_port_gps (MM_BASE_MODEM (self)))
sources |= (MM_MODEM_LOCATION_SOURCE_GPS_NMEA |
MM_MODEM_LOCATION_SOURCE_GPS_RAW |
MM_MODEM_LOCATION_SOURCE_GPS_UNMANAGED);
else
mm_dbg ("telit: GPS controller not supported: %s", error->message);
g_clear_error (&error);
g_task_return_int (task, sources);
g_object_unref (task);
}