SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

novatel: let generic CDMA class handle signal strength while connected

Browse Source 
Instead of returning an unhelpful error when there isn't a second
AT port (which there never will be for Novatel CDMA devices) we should
let the superclass handle the request.
This commit is contained in:
Dan Williams
2010-04-29 18:57:49 -07:00
parent 1864d8da07
commit fbfb7f8953
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/mm-modem-novatel-cdma.c
+7 -4
View File
@@ -143,15 +143,18 @@ get_signal_quality (MMModemCdma *modem,
{
MMCallbackInfo *info;
MMAtSerialPort *port;
MMModemCdma *parent_iface;
info = mm_callback_info_uint_new (MM_MODEM (modem), callback, user_data);
port = mm_generic_cdma_get_best_at_port (MM_GENERIC_CDMA (modem), &info->error);
port = mm_generic_cdma_get_best_at_port (MM_GENERIC_CDMA (modem), NULL);
if (!port) {
mm_callback_info_schedule (info);
/* Let the superclass handle it */
parent_iface = g_type_interface_peek_parent (MM_MODEM_CDMA_GET_INTERFACE (modem));
parent_iface->get_signal_quality (MM_MODEM_CDMA (modem), callback, user_data);
return;
}
info = mm_callback_info_uint_new (MM_MODEM (modem), callback, user_data);
/* Many Novatel CDMA cards don't report CSQ in standard 0 - 31 and the CSQ
* reply doesn't appear to be in positive dBm either; instead try the custom
* Novatel command for it.