Commit Graph
6766 Commits
Author SHA1 Message Date
Aleksander Morgado 28b0e2b439 modem-helpers: simplify logic to create array of GRegex
Iterate over the list of available patterns, instead of adding
them one by one.
2020-04-09 12:38:50 +00:00
Aleksander Morgado c78da3de7e broadband-modem: run +C5GREG state checks
The generic CREG parser is improved to also allow parsing +C5GREG
responses and URCs.
2020-04-09 12:38:50 +00:00
Aleksander Morgado 040eb3880c helpers: use generic number parsing methods in CREG parser
This fixes the s8500 wave unit test, which was incorrectly parsing the
Act field reported as 'B' as "GSM" (strtol(B)=0)

Also, given that the generic parsing methods are able to parse numbers
from quoted strings, this change allows us to remove the Thuraya
specific CREG matching that just took into consideration quoted
strings. The Thuraya unit tests are also fixed up to provide proper
testing of the logic.
2020-04-09 12:38:50 +00:00
Aleksander Morgado 40b36a25ca test,modem-helpers: remove obsolete comments in u-blox CREG tests
We already support "SMS only" registration state.
2020-04-09 12:38:50 +00:00
Aleksander Morgado ccb45a8941 libmm-glib,helpers: ignore all leading whitespaces when parsing numbers 2020-04-09 12:38:50 +00:00
Aleksander Morgado 7eee214b8e helpers: add additional AcT values from 27.007 2020-04-09 12:38:50 +00:00
Aleksander Morgado 68917f502e api: new 'attached RLOS' registration state
Reporting the state when the UE attaches to access restricted local
operator services.
2020-04-09 12:38:50 +00:00
Aleksander Morgado 1c7304eb71 libmm-glib,helpers: allow reading hex strings from match info 2020-04-09 12:38:50 +00:00
Aleksander Morgado 539562af01 libmm-glib,helpers: skip quotes when reading numbers from match infos
Useful when the regex applied to the parseable strings don't have an
special ignore rule for the quotes.
2020-04-09 12:38:50 +00:00
Aleksander Morgado 44ace9642c modem-helpers: improved +WS46 mode '25' handling
The mode '25' means different things on LTE-capable and
non-LTE-capable devices, so improve the logic to clarify that.
2020-04-09 12:38:50 +00:00
Aleksander Morgado f31182c08d iface-modem-3gpp: don't fixup CS network support
This is already done by the modem interface as soon as current
capabilities are loaded.
2020-04-09 12:38:50 +00:00
Aleksander Morgado 05301f23a1 iface-modem-3gpp: new 5GS network support 2020-04-09 12:38:50 +00:00
Aleksander Morgado 9144a9fa34 helpers-qmi: support 5G capabilities and modes 2020-04-09 12:38:50 +00:00
Aleksander Morgado 1cfd5daf9b api: new 5GNR access technology 2020-04-09 12:38:50 +00:00
Aleksander Morgado f912de3574 broadband-modem: support 5G in +WS46 to capabilities conversion 2020-04-09 12:38:50 +00:00
Aleksander Morgado 5db3fa88e9 api: new 5G mode 2020-04-09 12:38:50 +00:00
Aleksander Morgado 7354dc928f api: new 5GNR capability 2020-04-09 12:38:50 +00:00
Aleksander Morgado bf771be7fa build: require libqmi 1.25.4 for full 5G enum support 2020-04-09 12:38:49 +00:00
Aleksander Morgado 0cd76bf1c4 api: deprecate MM_MODEM_CAPABILITY_LTE_ADVANCED
It's not used anywhere.
2020-04-09 12:38:49 +00:00
Aleksander Morgado 78266ac489 iface-modem: simplify is_cdma_only() check
The check needs to look for a matching single bit, so no need to make
it too complex.
2020-04-09 12:38:49 +00:00
Aleksander Morgado e1cfe3b4ee api,cdma: fix small typo
Reported by Malte Grosse.
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/202#note_460466
2020-04-09 14:36:47 +02:00
Aleksander Morgado 1a67db047e cli: improve --help output for --modem and --sim options
Specify the full list of supported object lookup methods.
2020-04-09 05:38:07 +00:00
Aleksander Morgado d72a9df041 cli: allow looking up for first available modem or SIM
When a system only has one single modem, it's convenient to just look
for the first available modem or SIM object, instead of needing to
provide the full path or the exact index number.

This improvement allows users to use the "any" keyword, or any of its
substrings (e.g. "an" or even "a") to match the first available object
of the requested type.

E.g.:

  $ mmcli -m a
    --------------------------------
    General  |            dbus path: /org/freedesktop/ModemManager1/Modem/0
             |            device id: 1a48f1180f1fb0166d91f7b139d027136b59ba63
    --------------------------------
    Hardware |         manufacturer: Sierra Wireless Inc.
             |                model: Sierra Wireless EM7345 4G LTE
    ...

Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/196
2020-04-09 05:38:07 +00:00
Aleksander Morgado cc99ab562b cli: consolidate logic to process user provided object lookup info
The user may specify DBus objects in several ways, e.g. with full
object paths, just with the object numeric ids, or in some other cases
with the full device UID.

Setup one single method to process this info for all object types, so
that it's also easier to add new lookup methods for all at the same
time.
2020-04-09 05:38:07 +00:00
Aleksander Morgado 6f82ea3732 log: force using the object logging API
Unless the generic API is explicitly allowed, as in the main.c source
file.
2020-04-09 07:35:56 +02:00
Aleksander Morgado 956dc8a704 api,3gpp: fix InitialEpsBearerSettings documentation 2020-04-09 07:12:18 +02:00
Aleksander Morgado 57ad6654ba api,3gpp: add "Pco" property detailed documentation 2020-04-09 07:09:26 +02:00
Aleksander Morgado 962fe8bdb8 api,simple: fix name of access-technologies field in GetStatus() 2020-04-09 06:46:02 +02:00
Aleksander Morgado 839e2ec7ab api,modem: reword the properties argument explanation in CreateBearer() 2020-04-09 06:46:02 +02:00
Aleksander Morgado 6de1363174 api,modem: improve capabilities related documentation
And remove the unused mm_common_build_capability_combinations_any()
method in the common non-public library code.
2020-04-09 06:46:02 +02:00
Aleksander Morgado 382b059c1e po: update source code lines 2020-04-08 17:53:42 +02:00
Aleksander Morgado 93e4c8625b plugin: don't match generic plugin by name 2020-04-08 17:53:42 +02:00
Aleksander Morgado 4b058872a0 plugins: don't add plugin name in log message explicitly 2020-04-08 17:53:42 +02:00
Aleksander Morgado 8722215f7e plugins: use logging module name as plugin name 2020-04-08 17:53:42 +02:00
Aleksander Morgado 997e2cefb8 log: define per-module logging for shared utils and plugins 2020-04-08 17:53:42 +02:00
Aleksander Morgado e956bac47b log: common logging method definition for all testers and helpers 2020-04-08 17:53:42 +02:00
Aleksander Morgado f1e930d574 core: consolidate logging format in main daemon logic 2020-04-08 16:35:10 +02:00
Aleksander Morgado 4508c11796 zte: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado 35554aaeed xmm: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado 9c9e531130 x22x: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado ab47b56573 wavecom: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado c891595e3f via: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado ccd0f6de5a ublox: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado e04aa0ea5d tplink: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado 94a1559751 thuraya: no logging in plugin 2020-04-08 16:35:10 +02:00
Aleksander Morgado 98631e140e thuraya: return GError in custom CPMS parser 2020-04-08 16:35:10 +02:00
Aleksander Morgado 078c638165 telit: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado 9dbc346f93 simtech: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado d15da9cf60 sierra: port to use object logging 2020-04-08 16:35:10 +02:00
Aleksander Morgado aed9f46443 samsung: port to use object logging 2020-04-08 16:35:09 +02:00